lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fergus McMenemie (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (SOLR-1033) DIH transformers cannot reuse output from previous transformations
Date Mon, 23 Feb 2009 23:08:01 GMT

    [ https://issues.apache.org/jira/browse/SOLR-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675969#action_12675969
] 

fergus edited comment on SOLR-1033 at 2/23/09 3:06 PM:
-----------------------------------------------------------------

Your comment about modifying the system "to have the current entities rows be available always
to all transformers" is good and will produce the fastest most efficient code. 

But I need to sure we are not using the term "template" twice in different ways. You say "you
are constructing the regex replacements themselves with templates" by which you mean using
the ${XXX} syntax and not the output from a templatetransformer?

Anyway I have backed out my patch and applied yours. Everything seems fine, but I am still
testing.

Thanks very much.

      was (Author: fergus):
    Your comment about modifying the system "to have the current entities rows be available
always to all transformers" is good and will produce the fastest most efficient code. 

But I need to sure we are not using the term "template" twice in different ways. You say "you
are constructing the regex replacements themselves with templates" by which you mean using
the ${XXX} syntax and not the output from a templatetransformer?

Also, is your patch a replacement for mine?
  
> DIH transformers cannot reuse output from previous transformations
> ------------------------------------------------------------------
>
>                 Key: SOLR-1033
>                 URL: https://issues.apache.org/jira/browse/SOLR-1033
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: All operating systems and software platforms
>            Reporter: Fergus McMenemie
>             Fix For: 1.4
>
>         Attachments: SOLR-1033.patch, SOLR-1033.patch, SOLR-1033.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> It can be very useful to reuse the output from a DIH template in other templates and
or regex transformers. Currently this cannot be done. The resolver is initialized at the start
of the transformer run with what ever values exist for a column name at that instant. As the
transformer executes it may define new values for column names. My change is intended to update
the hash used by the resolver after each successful transformation.
> This only applies to the template and regex transformers.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message