Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@minotaur.apache.org Received: (qmail 63032 invoked from network); 27 Jan 2009 07:03:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Jan 2009 07:03:28 -0000 Received: (qmail 46046 invoked by uid 500); 27 Jan 2009 07:03:26 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 46012 invoked by uid 500); 27 Jan 2009 07:03:26 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 46001 invoked by uid 99); 27 Jan 2009 07:03:26 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jan 2009 23:03:26 -0800 X-ASF-Spam-Status: No, hits=-1999.8 required=10.0 tests=ALL_TRUSTED,WHOIS_MYPRIVREG X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 27 Jan 2009 07:03:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 94D6F234C48C for ; Mon, 26 Jan 2009 23:02:59 -0800 (PST) Message-ID: <924218249.1233039779608.JavaMail.jira@brutus> Date: Mon, 26 Jan 2009 23:02:59 -0800 (PST) From: "Shalin Shekhar Mangar (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Commented: (SOLR-974) DataImportHandler should not commit if no data has been updated In-Reply-To: <1459032535.1232560799659.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667600#action_12667600 ] Shalin Shekhar Mangar commented on SOLR-974: -------------------------------------------- bq. I guess the best thing is to expose the 'stats' as a variable in DIH. This can also be exposed through the Context#getStats() I like this idea. I'll give a patch. > DataImportHandler should not commit if no data has been updated > --------------------------------------------------------------- > > Key: SOLR-974 > URL: https://issues.apache.org/jira/browse/SOLR-974 > Project: Solr > Issue Type: Improvement > Components: contrib - DataImportHandler > Affects Versions: 1.3 > Reporter: Wojtek Piaseczny > Assignee: Shalin Shekhar Mangar > Priority: Minor > Fix For: 1.4 > > Attachments: SOLR-974.patch, SOLR-974.patch > > > The DataImportHandler always finishes an import with a commit, even if it retrieved no data from its data source. Add a short circuit to not commit if no data was imported. > Related discussion: > http://www.nabble.com/Performance-Hit-for-Zero-Record-Dataimport-td21572935.html -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.