Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@locus.apache.org Received: (qmail 38060 invoked from network); 26 Jan 2009 15:38:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Jan 2009 15:38:25 -0000 Received: (qmail 61275 invoked by uid 500); 26 Jan 2009 15:38:21 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 61248 invoked by uid 500); 26 Jan 2009 15:38:21 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 60945 invoked by uid 99); 26 Jan 2009 15:38:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jan 2009 07:38:20 -0800 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Jan 2009 15:38:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A1E1D234C4A9 for ; Mon, 26 Jan 2009 07:37:59 -0800 (PST) Message-ID: <526488681.1232984279661.JavaMail.jira@brutus> Date: Mon, 26 Jan 2009 07:37:59 -0800 (PST) From: "Noble Paul (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Commented: (SOLR-985) TemplateString is not thread-safe In-Reply-To: <1722210538.1232981159600.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667267#action_12667267 ] Noble Paul commented on SOLR-985: --------------------------------- making that instance non-static should be fine. right? > TemplateString is not thread-safe > --------------------------------- > > Key: SOLR-985 > URL: https://issues.apache.org/jira/browse/SOLR-985 > Project: Solr > Issue Type: Bug > Components: contrib - DataImportHandler > Affects Versions: 1.3 > Reporter: Ryuuichi Kumai > Attachments: SOLR-985.patch > > > TemplateString is not thread-safe but it is being used concurrently by many cores due to the static instance. > Currently TemplateString#cache is not synchronized, and static instance of TemplateString is used by VariableResolverImpl#replaceTokens(). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.