lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kay Kay (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-969) Context#FULL_DUMP, DELTA_DUMP, FIND_DELTA as an enum
Date Wed, 21 Jan 2009 16:37:59 GMT

    [ https://issues.apache.org/jira/browse/SOLR-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12665876#action_12665876
] 

Kay Kay commented on SOLR-969:
------------------------------

| It was not made an enum because I wamted them to be used in non-java languages (like javascript)


Going back to the original issue - I am sure there would be some way to map the enum objects
in java to javascript when it comes to porting the same. Until then ignoring type-safety seems
to be ripe for errors ( A good number of test cases seem to pass a 0, as of today in place
of ImportProcess in the ContextImpl ctor. when 0 makes no sense at all and another piece of
code uses a -1 to check if it is an invalid process i.e. other than full import, delta import,
find delta etc. ).  

> Context#FULL_DUMP, DELTA_DUMP, FIND_DELTA as an enum 
> -----------------------------------------------------
>
>                 Key: SOLR-969
>                 URL: https://issues.apache.org/jira/browse/SOLR-969
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>         Environment: Java 6, Tomcat 6
>            Reporter: Kay Kay
>             Fix For: 1.4
>
>         Attachments: SOLR-969.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Context # FULL_DUMP,  DELTA_DUMP, FIND_DELTA made type-safe as an enum. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message