Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Message-ID: <1092400039.1229277824233.JavaMail.jira@brutus>
Date: Sun, 14 Dec 2008 10:03:44 -0800 (PST)
From: "Shalin Shekhar Mangar (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Resolved: (SOLR-913) org/apache/solr/handler/SnapPuller.java
  - Expensive Pattern object made static
In-Reply-To: <1769750203.1229274944200.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/SOLR-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-913.
----------------------------------------

    Resolution: Won't Fix

Marking as won't fix because the readInterval method is called only on core startup and it is better to create and throw away Pattern object rather then keep it in static.

Thanks for going through the code Kay, please keep the suggestions coming :)

> org/apache/solr/handler/SnapPuller.java  - Expensive Pattern object made static 
> --------------------------------------------------------------------------------
>
>                 Key: SOLR-913
>                 URL: https://issues.apache.org/jira/browse/SOLR-913
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>         Environment: Tomcat 6, JRE 6 
>            Reporter: Kay Kay
>             Fix For: 1.4
>
>         Attachments: SOLR-913.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> In the class -  org.apache.solr.handler.SnapPuller - there seems to be an expensive Pattern object created locally in the method 
>   static Integer readInterval(String interval) ; 
> Pattern instances are better created as static objects and reused. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.