lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wojtek Piaseczny (JIRA)" <>
Subject [jira] Commented: (SOLR-748) FacetComponent helper classes are package restricted
Date Sat, 20 Sep 2008 17:03:44 GMT


Wojtek Piaseczny commented on SOLR-748:

Are there any objections to committing this patch? 

I realize I didn't mention exactly what I'm using this for. I want to override the finishStage
method of the FacetComponent class in my own facet component. To use values calculated by
the default behavior of the FacetComponent class, I need several classes to be public (the
ones listed above). 

> FacetComponent helper classes are package restricted
> ----------------------------------------------------
>                 Key: SOLR-748
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Wojtek Piaseczny
>             Fix For: 1.4
>         Attachments: 748.patch, SOLR-748.patch
> Original discussion:
> The FacetComponent class uses several helper classes that currently have package-restricted
access. This makes it impossible to extend the FacetComponent without rewriting most of its
> A proposed solution is to make those classes public and make their public member variables
accessibly only through get and set functions (i.e. make them private).

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message