lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-765) ant example fails if example/work directory doesn't exist
Date Mon, 22 Sep 2008 19:03:44 GMT

    [ https://issues.apache.org/jira/browse/SOLR-765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12633436#action_12633436
] 

Hoss Man commented on SOLR-765:
-------------------------------


1) my previous comment was in regards to your "possible to check for the existence and create
them/ignore errors in the build script" statement

2) regarding the patch: it can do harm.  I could have sworn i posted a comment about this
before resolving but clearly i forgot to hit submit or something...

The purpose cleaning out the work directory is to provide a safety check to ensure that an
older copy of the webapp (with old jars) isn't left lying around where Jetty might pick it
up and use it by mistake -- it's not suppose to happen but it can.  If we use failonerror="false"
it won't just silently ignore a missing work directly, it will also silently ignore any situation
where files in the work directory can't be deleted by ant (because of the way the perms are
set, or because windows prevents open files from being deleted, etc..) which means the whole
point (the safety check) is gone --  people will unwittingly be using old jars and banging
their heads against their keyboards not knowing why

> ant example fails if example/work directory doesn't exist
> ---------------------------------------------------------
>
>                 Key: SOLR-765
>                 URL: https://issues.apache.org/jira/browse/SOLR-765
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Lars Kotthoff
>            Priority: Minor
>         Attachments: SOLR-765.patch
>
>
> Running "ant example" when there's no example/work directory causes the build to fail
because the task tries to delete the (non-existent) directory.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message