lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Biestro (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-724) CoreDescriptor.{get,set}CoreExpressions should probably not be public (but package private)
Date Mon, 25 Aug 2008 09:25:44 GMT

    [ https://issues.apache.org/jira/browse/SOLR-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625287#action_12625287
] 

Henri Biestro commented on SOLR-724:
------------------------------------

Yes, correct; properties, not expressions.
They are unnecessary since the CoreContainer & each SolrCore resource loader could (will
hopefully) contain the evaluated properties.
That would make 2 places where we can access them & this seems redundant.
I'm just trying to reduce public method exposure.

> CoreDescriptor.{get,set}CoreExpressions should probably not be public (but package private)
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-724
>                 URL: https://issues.apache.org/jira/browse/SOLR-724
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Henri Biestro
>            Priority: Minor
>
> Exposing them precludes being ever able to fill the CoreDescriptor with property expressions.
> Since a 'public' method can not be removed easily, this is a future problem.
> Besides, as is, their is no reason for them to be public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message