lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-647) Do SolrCore.close() in a refcounted way
Date Tue, 12 Aug 2008 15:12:44 GMT

    [ https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621849#action_12621849
] 

Grant Ingersoll commented on SOLR-647:
--------------------------------------

{quote}
How else can I reload the core in a single core deployment?
{quote}

In email, I said, "OK, I'll buy that, maybe I just don't get Multicore/Single Core relationship.
 Also, reload is not used anywhere and we've never had the notion of reloading in the single
core case, AFAICT."

But, thinking about it some more, I guess I don't.  The descriptor up until this patch, was
merely a container for storing core information, hence the name.  Now all of a sudden it has
reload capabilities (but, it doesn't have open/close capabilities to go with it) so it just
doesn't fit in my mind.

> Do SolrCore.close() in a refcounted way
> ---------------------------------------
>
>                 Key: SOLR-647
>                 URL: https://issues.apache.org/jira/browse/SOLR-647
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>         Attachments: solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
solr-647.patch, SOLR-647.patch, SOLR-647.patch
>
>
> The method _SolrCore.close()_ directly closes the core . It can cause Exceptions for
in-flight requests. The _close()_ method should just do a decrement on refcount and the actual
close must happen when the last request being processed by that core instance is completed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message