lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Grant Ingersoll (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-647) Do SolrCore.close() in a refcounted way
Date Tue, 12 Aug 2008 13:24:44 GMT

    [ https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621812#action_12621812
] 

Grant Ingersoll commented on SOLR-647:
--------------------------------------

I'd like to see some more documentation on this.  Namely, when should SolrCore.Reference be
used, etc.  This may just be for my own edification.  For instance, what's the relationship
in MultiCore between getCore and acquireCore and openCore?  (Since openCore just calls acquireCore
w/ a null reference, we probably should just call it acquireCore as well.)

Also, when do would I call Reference.release() versus core.close()?

How does CoreDescriptor.reloadCore factor in?   I don't see that it is used.  Why would I
call that instead of MultiCore.reload()?

Part of these questions may just be bigger questions related to Multicore all together.

> Do SolrCore.close() in a refcounted way
> ---------------------------------------
>
>                 Key: SOLR-647
>                 URL: https://issues.apache.org/jira/browse/SOLR-647
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.3
>            Reporter: Noble Paul
>             Fix For: 1.3
>
>         Attachments: solr-647.patch, solr-647.patch, solr-647.patch, solr-647.patch,
solr-647.patch, SOLR-647.patch, SOLR-647.patch
>
>
> The method _SolrCore.close()_ directly closes the core . It can cause Exceptions for
in-flight requests. The _close()_ method should just do a decrement on refcount and the actual
close must happen when the last request being processed by that core instance is completed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message