Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Received-SPF: pass (athena.apache.org: domain of noble.paul@gmail.com
 designates 72.14.220.159 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=rvHgidTmgUchITj8NzLZIygWX8i+xKILeqrerGjw/OEs6UE2zdXbsmTDkYfn7ZHz5VkRWvjUOH0wsgtDvhSp/5NZ3GWLBn17aTyFsfw9ptcQC+qX5bqQX3kGFVGqg6Uu5SI2vpzPXa0xJJsKfvgJOtH5xhEQaadTBCuFdDAFYEk=
Message-ID: <5e76b0ad0806012124m2cebc5a8seedbfc60ee8c5cba@mail.gmail.com>
Date: Mon, 2 Jun 2008 09:54:43 +0530
From: "=?UTF-8?B?Tm9ibGUgUGF1bCDgtKg=?=
 =?UTF-8?B?4LWL4LSs4LS/4LSz4LWN4oCNIOCkqOCli+CkrOCljeCks+CljQ==?="
 <noble.paul@gmail.com>
To: solr-dev@lucene.apache.org
Subject: Re: [Solr Wiki] Update of "Solr1.3" by HossMan
In-Reply-To: <20080601195051.22142.38843@eos.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080601195051.22142.38843@eos.apache.org>

Let us remove BinaryResponseWriter from the list.

The reason why it is has very-low coverage is because
# There are two methods implemented by the class which are there in
the interface but not used and the total lines itself is too small
# One instanceof added for completeness
88 	 0 	 if (o instanceof Document) {
 89 	 0 	return getDoc((Document) o);
 90 	   	}
 91 	   	
 92 	 0 	return o;

# The only lines which I am not sure are the following. I think the
check may be redundant

 131 	 3320 	 FieldType ft = schema.getFieldTypeNoEx(fieldName);
 132 	 3320 	Object val;
 133 	 3320 	if (ft==null) { // handle fields not in the schema
 134 	 0 	if (f.isBinary()) val = f.binaryValue();
 135 	 0 	else val = f.stringValue();
 136 	   	} else {
 137 	 3320 	val = useFieldObjects ? ft.toObject(f) : ft.toExternal(f);
 138 	   	}
everything else is fine
--Noble


On Mon, Jun 2, 2008 at 1:20 AM, Apache Wiki <wikidiffs@apache.org> wrote:
> Dear Wiki user,
>
> You have subscribed to a wiki page or wiki category on "Solr Wiki" for change notification.
>
> The following page has been changed by HossMan:
> http://wiki.apache.org/solr/Solr1%2e3
>
> ------------------------------------------------------------------------------
>  == TODO: Misc ==
>
>   * resolve multicore logging prefix.  I think otis suggested moving to the end for consistent log file parsers {{{ core.log.info(core.getLogId()+ ... }}}
> -  * code coverage reports are generally low, but some of the new classes in 1.3 that have frighteningly low coverage -- in many cases these seem like pretty important classes and/or high profile plugins.  numbers below as of May 26...
> +  * [http://hudson.zones.apache.org/hudson/job/Solr-trunk/clover/ code coverage reports] are generally low, but some of the new classes in 1.3 that have frighteningly low coverage -- in many cases these seem like pretty important classes and/or high profile plugins.  numbers below as of May 26...
>     * BinaryResponseWriter  (66.7%)
>     * BoostedQuery  (53.8%)
>     * BoostedQuery.CustomScorer  (50%)
>


-- 
--Noble Paul