Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@locus.apache.org Received: (qmail 41043 invoked from network); 6 Jun 2008 19:44:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Jun 2008 19:44:41 -0000 Received: (qmail 63504 invoked by uid 500); 6 Jun 2008 19:44:43 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 63475 invoked by uid 500); 6 Jun 2008 19:44:43 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 63464 invoked by uid 99); 6 Jun 2008 19:44:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jun 2008 12:44:43 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of tsmorton@gmail.com designates 64.233.166.182 as permitted sender) Received: from [64.233.166.182] (HELO py-out-1112.google.com) (64.233.166.182) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jun 2008 19:43:54 +0000 Received: by py-out-1112.google.com with SMTP id z74so722759pyg.9 for ; Fri, 06 Jun 2008 12:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type:references; bh=2m7XcC0M54NcLN9/E4VtXUe1XqtNNHSnYonMrIDFtlU=; b=HbJ3nVjA9lUeRfdgv+8pDnMkIV2+dnS7WFYAOxJxmyBm+wQXyCswjohhqrUYjMtiDj JLm3HuFSUA+/xrpqNPeFPu4ypS9kvy7Se5XHAOoVRExguWXS209MGIDfp1aeWEDzzsRr 4K0gV0zKeIZ7zrWJtMOCROnH3BvYzm9B9+hMU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:references; b=IgsB6VPiPD56XDhXnFIFVGYEbrQ9OU7wOox98aQ0h89d+tdBDk8DrLJrjDhpcabz0K cE6PN3cCefWnB4fvRUb9VjWi91j+Jd4SfvfnG8ZBaHG8QBMI4ZO2Qz7FTcK1tYNR8qRS S/b0hMBgGJtdyk4A2dVVh7TTpO985pSsZyIN4= Received: by 10.143.163.3 with SMTP id q3mr158026wfo.294.1212781450508; Fri, 06 Jun 2008 12:44:10 -0700 (PDT) Received: by 10.142.203.3 with HTTP; Fri, 6 Jun 2008 12:44:10 -0700 (PDT) Message-ID: <14ca6f30806061244g7dc3300fw4c03a336fdc61169@mail.gmail.com> Date: Fri, 6 Jun 2008 15:44:10 -0400 From: "Tom Morton" To: solr-dev@lucene.apache.org Subject: Re: Boosting for MoreLikeThisHandler In-Reply-To: <1DA62099-0788-4FD7-A897-FD16FFBB32AF@apache.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_5469_4329991.1212781450506" References: <14ca6f30806051233p42270aeao5ee370a7db06c088@mail.gmail.com> <1DA62099-0788-4FD7-A897-FD16FFBB32AF@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_5469_4329991.1212781450506 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline I'm trying to add some unit tests now. MoreLikeThisHandler had a minimal set of tests which don't actually test its output, just that fields and a query parameters are required. It'll take me a bit to write something for the regular version and then the version with specified boosts. On Fri, Jun 6, 2008 at 6:46 AM, Grant Ingersoll wrote: > I think a separate issue is warranted. Can you add unit tests, too? > > > On Jun 5, 2008, at 3:33 PM, Tom Morton wrote: > > Hi, >> SOLR-295 mentions boost support for morelikethis and then seems to have >> been subsumed by SOLR-281 but I don't think this got implemented. I've >> patched MoreLikeThisHandler to support this. Here's a summary of the >> approach: >> >> Parse out "mlt.qf parameters" to get boosts in dismax like format >> (existing code from DisMax param parse code used to produce a >> Map) >> Iterate through mltquery terms, get boost by looking at field from which >> mltquery term came, and multiply boost specified in map by existing term >> boost. >> If mlt.boost=false, then you get the same boost values as in map/mlt.qf >> parameters, >> If mlt.boost=true then you get normalized boost multiplied by specified >> boost (which makes sense to me). >> >> Patch attached. >> >> Should I re-open either SOLR-281 or SOLR-295 (if I can) or create a new >> jira ticket for this? >> >> Thanks...Tom >> >> > > > ------=_Part_5469_4329991.1212781450506--