lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-553) Highlighter does not match phrase queries correctly
Date Sun, 25 May 2008 10:37:55 GMT

    [ https://issues.apache.org/jira/browse/SOLR-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12599669#action_12599669
] 

Mark Miller commented on SOLR-553:
----------------------------------

Just to point out, as I am not sure its clear, the SpanScorer is just as fast as the old Scorer
when no Phrase's, or Span's are in the query. Mark H actually tested it as slightly faster,
though thats a bit odd.

When there is a Span or Phrase, none Span/Phrase clauses of the Query are still highlighted
the same and at the same speed as the original Scorer...it is just the Span/Phrase clauses
that fire up a MemoryIndex and have getSpans called against it.

So you really only pay for the extra position sensitive part where actually needed.

> Highlighter does not match phrase queries correctly
> ---------------------------------------------------
>
>                 Key: SOLR-553
>                 URL: https://issues.apache.org/jira/browse/SOLR-553
>             Project: Solr
>          Issue Type: New Feature
>          Components: highlighter
>    Affects Versions: 1.2
>         Environment: all
>            Reporter: Brian Whitman
>            Assignee: Otis Gospodnetic
>             Fix For: 1.3
>
>         Attachments: highlighttest.xml, SOLR-553-SC.patch, Solr-553.patch, Solr-553.patch,
Solr-553.patch
>
>
> http://www.nabble.com/highlighting-pt2%3A-returning-tokens-out-of-order-from-PhraseQuery-to16156718.html
> Say we search for the band "I Love You But I've Chosen Darkness"
> .../selectrows=100&q=%22I%20Love%20You%20But%20I\'ve%20Chosen%20Darkness%22&fq=type:html&hl=true&hl.fl=content&hl.fragsize=500&hl.snippets=5&hl.simple.pre=%3Cspan%3E&hl.simple.post=%3C/span%3E
> The highlight returns a snippet that does have the name altogether:
> Lights (Live) : <span>I</span> <span>Love</span> <span>You</span>
But <span>I've</span> <span>Chosen</span> <span>Darkness</span>
:
> But also returns unrelated snips from the same page:
> Black Francis Shop "<span>I</span> Think <span>I</span> <span>Love</span>
<span>You</span>"
> A correct highlighter should not return snippets that do not match the phrase exactly.
> LUCENE-794 (not yet committed, but seems to be ready) fixes up the problem from the Lucene
end. Solr should get it too.
> Related: SOLR-575 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message