Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: solr-dev@lucene.apache.org
Message-ID: <322255861.1203927531100.JavaMail.jira@brutus>
Date: Mon, 25 Feb 2008 00:18:51 -0800 (PST)
From: "Noble Paul (JIRA)" <jira@apache.org>
To: solr-dev@lucene.apache.org
Subject: [jira] Commented: (SOLR-486) Support binary formats for
 QueryresponseWriter
In-Reply-To: <1017867421.1203926931043.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/SOLR-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572024#action_12572024 ] 

Noble Paul commented on SOLR-486:
---------------------------------

Without breaking the existing stuff we can add another interface

BinaryQueryResponse extends QueryResponseWriter{
public void write(OutputStream out, SolrQueryRequest request,SolrQueryResponse response) throws IOException;

and in the SolrDispatchFilter add the following linesQueryResponseWriter responseWriter = core.getQueryResponseWriter(solrReq);

if (responseWriter instanceof BinaryQueryResponse ) {
               BinaryQueryResponse binaryResp = (Object)
responseWriter;
binaryResp.write(response.getOutputStream(), solrReq, solrRsp);
   } else {
      responseWriter.write(response.getWriter(), solrReq, solrRsp);
}

> Support binary formats for QueryresponseWriter
> ----------------------------------------------
>
>                 Key: SOLR-486
>                 URL: https://issues.apache.org/jira/browse/SOLR-486
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java, search
>            Reporter: Noble Paul
>            Priority: Minor
>             Fix For: 1.3
>
>
> QueryResponse writer only allows text data to be written.
> So it is not possible to implement a binary protocol . Create another interface which has a method 
> write(OutputStream os, SolrQueryRequest request, SolrQueryResponse response)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.