lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Keene, David" <dke...@soe.sony.com>
Subject RE: solrj patch to COMMIT with xml
Date Tue, 15 Jan 2008 21:05:35 GMT
Nope, I'm using 1.3 (synced 2 days ago).  I'm indexing using using code
similar to below, and it creates 2 connections when doing so.  Perhaps
there is a better way to do my indexing so the commit is included with
the add connction.

Sample indexing code:

UpdateResponse addResponse = client.add( docs );
UpdateResponse commitResponse = client.commit();

Is there a way to make the client.add(docs) connection add a commit?


-----Original Message-----
From: Ryan McKinley [mailto:ryantxu@gmail.com] 
Sent: Tuesday, January 15, 2008 12:54 PM
To: solr-dev@lucene.apache.org
Subject: Re: solrj patch to COMMIT with xml

Are you hitting a 1.2 solr index?  Using ?commit=true assumes you are 
hitting a 1.3 index...

The reason for it is so you can optionally add docs and commit in one
call.

ryan


Keene, David wrote:
> Hey guys,
> 
>  
> 
> I'm not sure why, but the solrj client relies on commit=true on the
> querystring for committing an index() call.  But with the latest svn
> trunk, my index() calls were not committing.  I made a patch to add a
> <COMMIT/> element to the posted xml so I could index using the solrj
> client.
> 
>  
> 
> Did I miss something about how to get commits working in 1.3?  Anyway,
> here's the patch if you want it.
> 
>  
> 
> Thanks,
> 
> Dave
> 
>  
> 
>  
> 
>  
> 
>  
> 
> Index: C:/Documents and
>
Settings/dkeene/workspace/solr.trunk/client/java/solrj/src/org/apache/so
> lr/client/solrj/request/UpdateRequest.java
> 
> ===================================================================
> 
> --- C:/Documents and
>
Settings/dkeene/workspace/solr.trunk/client/java/solrj/src/org/apache/so
> lr/client/solrj/request/UpdateRequest.java     (revision 611919)
> 
> +++ C:/Documents and
>
Settings/dkeene/workspace/solr.trunk/client/java/solrj/src/org/apache/so
> lr/client/solrj/request/UpdateRequest.java     (working copy)
> 
> @@ -171,7 +171,14 @@
> 
>        writer.append( "</delete>" );
> 
>      }
> 
>      
> 
> -    // If action is COMMIT or OPTIMIZE, it is sent with params
> 
> +    if (action != null ) {
> 
> +                                  if (action == ACTION.OPTIMIZE) {
> 
> +
> writer.append("<optimize/>");
> 
> +                                  } else if (action == ACTION.COMMIT)
{
> 
> +
> writer.append("<commit/>");
> 
> +                                  }
> 
> +    }
> 
> +    
> 
>      String xml = writer.toString();
> 
>      //System.out.println( "SEND:"+xml );
> 
>      return (xml.length() > 0) ? xml : null;
> 
> 


Mime
View raw message