lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-414) Coherent plugin initialization strategy
Date Sat, 08 Dec 2007 05:40:43 GMT

    [ https://issues.apache.org/jira/browse/SOLR-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12549653
] 

Hoss Man commented on SOLR-414:
-------------------------------

Henri: this comment concerns me...

> May I kindly suggest that if you -Hoss & Ryan- feel we can't close the
> topic yet, we at least commit it with an in-flux state?

...as far as i can tell Ryan already commited all of the SolrCoreAware and ResourceLoader
stuff back on Nov24 ... is there more to this issue that you feel is missing and still needs
committed?


And just to clarify one thing...

> Hoss,   
> Are you suggesting dropping SolrCoreAware and replace it with IndexSchemaAware ?

No, SolrCoreAware should serve a valuable purpose for plugins that historicaly might have
accessed one of the singletons from an init() method -- i was just suggesting that an IndexSchemaAware
API might (someday) be handy analysis type plugins that want an equally tight "call back"
coupling with the IndexSchema when it's initialized.

> Coherent plugin initialization strategy
> ---------------------------------------
>
>                 Key: SOLR-414
>                 URL: https://issues.apache.org/jira/browse/SOLR-414
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>             Fix For: 1.3
>
>         Attachments: SOLR-414-Initialization.patch, SOLR-414-Initialization.patch, SOLR-414-Initialization.patch,
SOLR-414-Initialization.patch, SOLR-414-Initialization.patch
>
>
> We currently load many plugins with a Map or NamedList -- since SOLR-215, the current
core is not available through SolrCore.getSolrCore() and may need to be used for initialization.
> Ideally, we could change the init() methods from:
> {panel}void init( final Map<String,String> args );{panel}
> to
> {panel}void init( final SolrCore core, final Map<String,String> args );{panel}
> Without breaking existing APIs, this change is difficult (some ugly options exist). 
This patch offers a solution to keep existing 1.2 APIs, and allow access to the SolrConfig
and SolrCore though ThreadLocal.  This should be removed in a future release.
> {panel}
>   DeprecatedPluginUtils.getCurrentCore();
>   DeprecatedPluginUtils.getCurrentConfig();
> {panel}
> This patch removes the SolrConfig.Initalizable that was introduced in SOLR-215.
> For background, see:
> http://www.nabble.com/Initializing---break-init%28%29-API-compatibility--tf4808463.html
> See also: SOLR-260, SOLR-215,  SOLR-399

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message