Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@locus.apache.org Received: (qmail 14035 invoked from network); 8 Nov 2007 20:39:14 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Nov 2007 20:39:14 -0000 Received: (qmail 63150 invoked by uid 500); 8 Nov 2007 20:39:01 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 63120 invoked by uid 500); 8 Nov 2007 20:39:01 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 63111 invoked by uid 99); 8 Nov 2007 20:39:01 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Nov 2007 12:39:01 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Nov 2007 20:39:48 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id CD4AD7141FE for ; Thu, 8 Nov 2007 12:38:50 -0800 (PST) Message-ID: <16832446.1194554330837.JavaMail.jira@brutus> Date: Thu, 8 Nov 2007 12:38:50 -0800 (PST) From: "Mike Klaas (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Commented: (SOLR-407) Uncached filter query parameters In-Reply-To: <13336007.1194396170943.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-407?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel#action_12541129 ]=20 Mike Klaas commented on SOLR-407: --------------------------------- Good catch! This can be fixed in standard request handler as follows: if(null !=3D ncFilters) { BooleanQuery target; if(query instanceof BooleanQuery) { target =3D (BooleanQuery)query; } else { target =3D new BooleanQuery(true); target.add(query, BooleanClause.Occur.MUST); } U.addFilters(ncFilters, target); query =3D target; } DisMax I don't think is a problem since it is adding to the top-level boole= an query (can the dismax parser produce pure negative queries anyway?) I've fixed this with a test in my local copy. If we pursue this any furthe= r, I'll post a patch (also incorporating Yonik's localParams suggestion). > Uncached filter query parameters > -------------------------------- > > Key: SOLR-407 > URL: https://issues.apache.org/jira/browse/SOLR-407 > Project: Solr > Issue Type: New Feature > Components: search > Affects Versions: 1.3 > Reporter: Mike Klaas > Assignee: Mike Klaas > Priority: Minor > Fix For: 1.3 > > Attachments: fq.nocache.patch > > > Add a fq.nocache parameter (that may be specified multiple times) that ad= ds filter clauses to the query which are not cached. Further, these filter= s are embedded directly into the BooleanQuery, which should be more efficie= nt when filters are=C2=A0not reused. --=20 This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.