From solr-dev-return-6299-apmail-lucene-solr-dev-archive=lucene.apache.org@lucene.apache.org Sat Nov 03 05:44:30 2007 Return-Path: Delivered-To: apmail-lucene-solr-dev-archive@locus.apache.org Received: (qmail 73065 invoked from network); 3 Nov 2007 05:44:30 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Nov 2007 05:44:30 -0000 Received: (qmail 8510 invoked by uid 500); 3 Nov 2007 05:43:32 -0000 Delivered-To: apmail-lucene-solr-dev-archive@lucene.apache.org Received: (qmail 8474 invoked by uid 500); 3 Nov 2007 05:43:32 -0000 Mailing-List: contact solr-dev-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-dev@lucene.apache.org Received: (qmail 8225 invoked by uid 99); 3 Nov 2007 05:43:31 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2007 22:43:30 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 03 Nov 2007 05:44:02 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id BEFF741013D for ; Fri, 2 Nov 2007 22:43:08 -0700 (PDT) Message-ID: <32782787.1194068588779.JavaMail.jira@brutus> Date: Fri, 2 Nov 2007 22:43:08 -0700 (PDT) From: "Dave Lewis (JIRA)" To: solr-dev@lucene.apache.org Subject: [jira] Commented: (SOLR-382) SpellCheckerRequestHandler does not apply the onlyMorePopular flag. In-Reply-To: <28226635.1192584590718.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/SOLR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539856 ] Dave Lewis commented on SOLR-382: --------------------------------- That's great Mike, thanks! And thanks for sprucing up the patch as well. :) dave > SpellCheckerRequestHandler does not apply the onlyMorePopular flag. > ------------------------------------------------------------------- > > Key: SOLR-382 > URL: https://issues.apache.org/jira/browse/SOLR-382 > Project: Solr > Issue Type: Bug > Components: spellchecker > Reporter: Dave Lewis > Assignee: Mike Klaas > Priority: Minor > Fix For: 1.3 > > Attachments: SpellCheckRequestHandler.patch > > > The onlyMorePopular member does not have its value changed to meet the parameter when it is passed in. On top of that, even when it is passed in, the suggestSimilar method on SpellChecker will ignore it anyway because the ir and field parameters are passed in as null. > This patch sets onlyMorePopular according to the request, and passes in a non-null IndexReader and the search field we've already initialized. > Because the IndexReader currently being used is named nullReader, I may be missing a reason it is disabled on purpose. > This patch is working well for us so far. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.