lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Lewis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-382) SpellCheckerRequestHandler does not apply the onlyMorePopular flag.
Date Sat, 03 Nov 2007 05:43:08 GMT

    [ https://issues.apache.org/jira/browse/SOLR-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539856
] 

Dave Lewis commented on SOLR-382:
---------------------------------

That's great Mike, thanks!  And thanks for sprucing up the patch as  
well. :)

dave





> SpellCheckerRequestHandler does not apply the onlyMorePopular flag.
> -------------------------------------------------------------------
>
>                 Key: SOLR-382
>                 URL: https://issues.apache.org/jira/browse/SOLR-382
>             Project: Solr
>          Issue Type: Bug
>          Components: spellchecker
>            Reporter: Dave Lewis
>            Assignee: Mike Klaas
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SpellCheckRequestHandler.patch
>
>
> The onlyMorePopular member does not have its value changed to meet the parameter when
it is passed in.  On top of that, even when it is passed in, the suggestSimilar method on
SpellChecker will ignore it anyway because the ir and field parameters are passed in as null.
> This patch sets onlyMorePopular according to the request, and passes in a non-null IndexReader
and the search field we've already initialized.
> Because the IndexReader currently being used is named nullReader, I may be missing a
reason it is disabled on purpose.
> This patch is working well for us so far.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message