lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Klaas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-407) Uncached filter query parameters
Date Thu, 08 Nov 2007 20:38:50 GMT

    [ https://issues.apache.org/jira/browse/SOLR-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541129
] 

Mike Klaas commented on SOLR-407:
---------------------------------

Good catch!  This can be fixed in standard request handler as follows:

if(null != ncFilters) {
        BooleanQuery target;
        if(query instanceof BooleanQuery) {
          target = (BooleanQuery)query;
        } else {
          target = new BooleanQuery(true);
          target.add(query, BooleanClause.Occur.MUST);
        }
        U.addFilters(ncFilters, target);
        query = target;
      }

DisMax I don't think is a problem since it is adding to the top-level boolean query (can the
dismax parser produce pure negative queries anyway?)

I've fixed this with a test in my local copy.  If we pursue this any further, I'll post a
patch (also incorporating Yonik's localParams suggestion).

> Uncached filter query parameters
> --------------------------------
>
>                 Key: SOLR-407
>                 URL: https://issues.apache.org/jira/browse/SOLR-407
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Mike Klaas
>            Assignee: Mike Klaas
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: fq.nocache.patch
>
>
> Add a fq.nocache parameter (that may be specified multiple times) that adds filter clauses
to the query which are not cached.  Further, these filters are embedded directly into the
BooleanQuery, which should be more efficient when filters are not reused.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message