lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Commented: (SOLR-258) Date based Facets
Date Wed, 25 Jul 2007 06:43:31 GMT


Hoss Man commented on SOLR-258:

> It is probably wise to explicitly check for ("end < start" XOR "gap < 0") and return
an error 

yeah ... good point.

> Just on the subject of errors, I notice that exceptions thrown by the date facet code
> caught in SimpleFacets.getFacetCounts() and written out in the response:
> This doesn't seem very consistent the way other handlers deal with exceptions (i.e. http

> response code > 400), is there any reason why it is done this way in SimpleFacets?

SimpleFacets isn't a handler, it's just a utility class that other handlers can use. 

 the original idea behind catching the errors and adding them to the response is that even
if a problem happens while generating facet counts, that's just auxiliary data -- and the
main result set is (probably) still useful, so let the request finish successfully so the
client can decide what to do.

> I also think it would also be a good idea to merge "facet_dates" response field into
> "facet_fields" so that all the facet data in the response is stored in the one location,
> feasible would it be to do this?

facet_dates and facet_fields are both children of single parent (facet_counts) just like facet_queries
... but they are in their own sub sections because the meaning and usecase are different ...
if they were all lumped together you couldn't pragmatically know what each of the children

> Date based Facets
> -----------------
>                 Key: SOLR-258
>                 URL:
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: date_facets.patch, date_facets.patch, date_facets.patch, date_facets.patch,
date_facets.patch, date_facets.patch, date_facets.patch
> 1) Allow clients to express concepts like...
>     * "give me facet counts per day for every day this month."
>     * "give me facet counts per hour for every hour of today."
>     * "give me facet counts per hour for every hour of a specific day."
>     * "give me facet counts per hour for every hour of a specific day and give me facet
counts for the 
>        number of matches before that day, or after that day." 
> 2) Return all data in a way that makes it easy to use to build filter queries on those
date ranges.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message