lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Wang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-243) Create a hook to allow custome code to create custome index readers
Date Tue, 12 Jun 2007 01:00:26 GMT

    [ https://issues.apache.org/jira/browse/SOLR-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503697
] 

John Wang commented on SOLR-243:
--------------------------------

Are you looking at the right patch?

For 1) at least, they are public.

2) I am using  Config.findClass

3) I just picked one from your suggestions, mainIndex is fine.

I feel I am jumping through quite a few arbitrary hoops just to contribute to an open source
project, and this is wrong and defeats the whole purpose of the idea of open source.

I think being more constructive and result oriented instead of being difficult and purist
can benefit this project much more. 

> Create a hook to allow custome code to create custome index readers
> -------------------------------------------------------------------
>
>                 Key: SOLR-243
>                 URL: https://issues.apache.org/jira/browse/SOLR-243
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>         Environment: Solr core
>            Reporter: John Wang
>             Fix For: 1.3
>
>         Attachments: indexReaderFactory.patch, indexReaderFactory.patch
>
>
> I have a customized IndexReader and I want to write a Solr plugin to use my derived IndexReader
implementation. Currently IndexReader instantiation is hard coded to be: 
> IndexReader.open(path)
> It would be really useful if this is done thru a plugable factory that can be configured,
e.g. IndexReaderFactory
> interface IndexReaderFactory{
>      IndexReader newReader(String name,String path);
> }
> the default implementation would just return: IndexReader.open(path)
> And in the newSearcher and getSearcher methods in SolrCore class can call the current
factory implementation to get the IndexReader instance and then build the SolrIndexSearcher
by passing in the reader.
> It would be really nice to add this improvement soon (This seems to be a trivial addition)
as our project really depends on this.
> Thanks
> -John

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message