lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tristan Vittorio (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (SOLR-275) PHP Serialized Response Writer
Date Tue, 26 Jun 2007 13:59:26 GMT

    [ https://issues.apache.org/jira/browse/SOLR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12508178
] 

Tristan Vittorio edited comment on SOLR-275 at 6/26/07 6:59 AM:
----------------------------------------------------------------

Hi Nick,

Thanks for submitting your PHPResponseWriter code, it seems to work pretty well, however I
needed to made a couple of minor changes to get it to compile with the current svn trunk:

27,28c27,28
< import org.apache.solr.util.NamedList;
< import org.apache.solr.util.SimpleOrderedMap;
---
> import org.apache.solr.common.util.NamedList;
> import org.apache.solr.common.util.SimpleOrderedMap;

The updated code I submitted also fixes a bug that caused the serialized data to be corrupt
when "score" was not included in the return fields list:

162c162
<     writer.write("a:4:{");
---
>     writer.write("a:"+(includeScore ? 4 : 3)+":{");

since if score was not included, the "response" array contained only three values rather than
four.

Hopefully we can get a few more people testing this code thoroughly to make sure it works
in all cases, since the PHP unserialize() function is very unforgiving on badly formatted
data!

cheers,
Tristan


 was:
Updated version of the original PHPResponseWriter.java patched to compile in the current svn
trunk and fix a bug that caused corrupted serialized data when "score" was not included in
the return fields list.

> PHP Serialized Response Writer
> ------------------------------
>
>                 Key: SOLR-275
>                 URL: https://issues.apache.org/jira/browse/SOLR-275
>             Project: Solr
>          Issue Type: New Feature
>          Components: clients - php
>    Affects Versions: 1.2
>            Reporter: Nick Jenkin
>            Priority: Minor
>         Attachments: PHPResponseWriter.java, PHPResponseWriter.java
>
>
> A PHP response writer that returns a serialized array that can be used with the PHP function
unserialize ( http://php.net/unserialize )
> Built off the JSON Writer
> I was not sure if this should be merged with https://issues.apache.org/jira/browse/SOLR-196
> I have tried to keep code duplication very minimal, but always room for improvement!
> Place PHPResponseWriter.java in src/org/apache/solr/request
> Add the below to your solrconfig.xml:
> <queryResponseWriter name="php" class="org.apache.solr.request.PHPResponseWriter"/>
> Description of PHP serialization format: http://www.hurring.com/scott/code/perl/serialize/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message