[ https://issues.apache.org/jira/browse/SOLR-135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504156
]
Ryan McKinley commented on SOLR-135:
------------------------------------
> do we want to rework the packages too?
I think now is as good of a time as any. I agree that having independent jar files with classes
in the same package is less then great.
> on the other hand it does have very HTTP specific error codes in it.
>
I don't see any problem with HTTP status codes in the base class. It seems standard enough.
I think we may want to have multiple error types that overlap with the same HTTP status code
(500)
(Not now, but...) I would like to see typed exceptions so they could be handled differently
-- BadRequestException() etc...
> Restructure / Refactor codebase for shared libraries
> ----------------------------------------------------
>
> Key: SOLR-135
> URL: https://issues.apache.org/jira/browse/SOLR-135
> Project: Solr
> Issue Type: Wish
> Reporter: Ryan McKinley
> Priority: Minor
> Attachments: SOLR-135-RestructureForCommonJar.patch, SOLR-135-RestructureForCommonJar.patch,
SOLR-135-RestructureForCommonJar.patch
>
>
> For SOLR-20 and other java projects, it would be nice to have common code share a codebase
that does not require lucene or junit to compile.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|