lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-234) TrimFilter should update the start and end offsets
Date Fri, 11 May 2007 20:58:15 GMT

    [ https://issues.apache.org/jira/browse/SOLR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495161
] 

Yonik Seeley commented on SOLR-234:
-----------------------------------

> What should happen with the position increment? 
It should remain the same as the original.

> The case i can imagine leading to something like SOLR-42 is if a token is replaced with
something
> that has leading or trailing spaces. 

Really whacky, but possible I guess.  I don't know of any token filters that would do that,
unless someone explicitly used a synonym with spaces at the end.  It doesn't make any sense.
I'd think that updating the offsets is almost always the right thing to do (and should be
the default?), given that spaces will almost always come from the field value itself.

-Yonik

> TrimFilter should update the start and end offsets
> --------------------------------------------------
>
>                 Key: SOLR-234
>                 URL: https://issues.apache.org/jira/browse/SOLR-234
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-234-TrimFilterOffsets.patch, SOLR-234-TrimFilterOffsets.patch
>
>
> As implemented, the TrimFilter only trims the text.  It does not update the the startOffset
and endOffset
> see:
> http://www.nabble.com/TrimFilter----t.startOffset%28%29%2C-t.endOffset%28%29-tf3728875.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message