lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan McKinley (JIRA)" <>
Subject [jira] Updated: (SOLR-181) Support for "Required" field Property
Date Sat, 28 Apr 2007 23:24:15 GMT


Ryan McKinley updated SOLR-181:

    Attachment: solr-181-required-fields.patch

Finally got a chance to look at this.  It looks good.  I made a few modifications:

1. changed tabs to spaces
2. Added javadoc comments to make it clear that RequiredFields must contain all fieldsWithDefaultValues
3. The error now contains the documents uniqueKey
4. moved the test to o.a.s.schema
5. I added a non-final flag to SchemaField to say if the field is required.
6. Modified to set the uniqueKey as required *unless* it is specified as
required="false" in the schema
7. Added required="true" to the example schema.xml 
8. Added required="false" to the test schema.xml (one test does not include it)

As a note to anyone else looking at the change log, Greg's patch also modifies AbstractSolrTestCase
and TestHarness to be able to check what status is expected from checkUpdateU

I think this offers a good solution to the (mis)feature that you could have a null uniqueKey.
 This patch lets you have a null uniqueKey, but you have to configure it.

> Support for "Required" field Property
> -------------------------------------
>                 Key: SOLR-181
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Greg Ludington
>            Priority: Minor
>         Attachments: solr-181-required-fields.patch, solr-181-required-fields.patch
> In certain situations, it can be helpful to require every document in your index has
a value for a given field.  While ideally the indexing client(s) should be responsible enough
to add all necessary fields, this patch allows it to be enforced in the Solr schema, by adding
a required property to a field entry.  For example, with this in the schema:
>    <field name="name" type="nametext" indexed="true" stored="true" required="true"/>
> A request to index a document without a name field will result in this response:
> <result status="1">org.apache.solr.core.SolrException: missing required fields:
> (and then, of course, the stack trace)
> </result>
> The meat of this patch is that DocumentBuilder.getDoc() throws a SolrException if not
all required fields have values; this may not work well as is with SOLR-139, Support updateable/modifiable
documents, and may have to be changed depending on that issue's final disposition.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message