lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-182) register SolrRequestHandlers at runtime / lazy loading
Date Mon, 26 Mar 2007 15:43:32 GMT

    [ https://issues.apache.org/jira/browse/SOLR-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484140
] 

Yonik Seeley commented on SOLR-182:
-----------------------------------

> (saves memory, but delays errors) 
Delays errors can also be a feature (if things need to be configured first, or jars need to
be dropped in the right spot, etc).

I think getWrappedHandler() needs to by synchronized or else
 - multiple instances could be instantiated
 - an instantiated instance could be handed back to a different thread before or during the
handler's init()
 - general spookiness even after init() finishes due to lack of synchronization (initialized
data won't necessarily be seen correctly in a different thread)


> register SolrRequestHandlers at runtime / lazy loading
> ------------------------------------------------------
>
>                 Key: SOLR-182
>                 URL: https://issues.apache.org/jira/browse/SOLR-182
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: SOLR-182-RuntimeRequestHandlers.patch, SOLR-182-RuntimeRequestHandlers.patch,
SOLR-182-RuntimeRequestHandlers.patch, SOLR-182-RuntimeRequestHandlers.patch, SOLR-182-RuntimeRequestHandlers.patch,
SOLR-182-RuntimeRequestHandlers.patch
>
>
> It would be useful to be able to register handlers after SolrCore has been initialized
initialized.  It is also useful to be able to ask what handlers are registered and to where.
 This patch adds the following functions to SolrCore:
> SolrRequestHandler registerRequestHandler(String handlerName, SolrRequestHandler handler);
> Collection<SolrRequestHandler> getRequestHandlers(Class<? extends SolrRequestHandler>
clazz);
> It also guarantees that request handlers will be initialized with an argument saying
what path it is registered to.  RequestHandlerBase gets a bean for the registered path.
> While discussing this, Yonik suggested making it possible to defer initialization of
some handlers that will be infrequently used.  I added the 'LazyRequestHandlerWrapper'  (if
taking this out makes the patch any easier to commit - it can get its own issue)
> check:
> http://www.nabble.com/Dynamic-RequestHandler-loading-tf3351707.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message