lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] Commented: (SOLR-174) Add multi-param support to qf,pf,bf,bq
Date Sun, 04 Mar 2007 17:30:50 GMT


Hoss Man commented on SOLR-174:

Mike: patch reads nice and clean to me (didn't try applying though)

two nits: 

1) it would be good to have a test of the case where a boolean with the default boost is specified
in one bq, and a seperate blank bq is specified to force the first BQ to be treated as a single

2) let's assign  params.getParams(DMP.BQ) to a temp variable so we don't have to call it twice
in three lines.

> Add multi-param support to qf,pf,bf,bq
> --------------------------------------
>                 Key: SOLR-174
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.2
>            Reporter: Mike Klaas
>         Assigned To: Mike Klaas
>            Priority: Minor
>             Fix For: 1.2
>         Attachments: multiparam.patch, multiparam.patch
> A quick patch that adds multi-params support for the listed dismax params.
> I opened an issue to get some feedback on the bq situation.  I left the subquery-extraction
logic as in, applying it to each specified boost query.  I'm not sure this is still valid
given coordFactor and such.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message