lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan McKinley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-183) add getRequiredParameter() to SolrParams
Date Wed, 07 Mar 2007 22:37:24 GMT

    [ https://issues.apache.org/jira/browse/SOLR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478934
] 

Ryan McKinley commented on SOLR-183:
------------------------------------

It seems bad to have the requited params be user configurable.  The real use case is that
the RequestHandler developer wants to ask for a parameter and know that the error checking
is taken care of.  

If the required params are configured externally, you run the risk of them getting out of
sync with the handler code - not to mention that it really isn't something that should be
configured.  If misconfigured you get a null pointer exception rather then 400...  defeating
the purpose altogether.

> add getRequiredParameter() to SolrParams
> ----------------------------------------
>
>                 Key: SOLR-183
>                 URL: https://issues.apache.org/jira/browse/SOLR-183
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Ryan McKinley
>            Priority: Trivial
>         Attachments: RequiredSolrParams.java, SOLR-183-required-param.patch, SOLR-183-required-param.patch
>
>
> I find myself including this with every patch, so i'll just separate it out.  This simply
adds a utilty function to SolrParams that throws a 400 if the parameter is missing:
> /** returns the value of the param, or throws a 400 exception if missing */
>   public String getRequiredParameter(String param) throws SolrException {
>     String val = get(param);
>     if( val == null ) {
>       throw new SolrException( 400, "Missing parameter: "+param );
>     }
>     return val;
>   }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message