lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan McKinley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-104) Update Plugins
Date Sun, 14 Jan 2007 23:27:27 GMT

    [ https://issues.apache.org/jira/browse/SOLR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12464640
] 

Ryan McKinley commented on SOLR-104:
------------------------------------

I just upload a new version of HandlerRefactoring-DRAFT-SRC.zip

In addition to the 8 files above, also delete:
src/java/org/apache/solr/request/SolrQueryResponse.java
src/webapp/src/org/apache/solr/servlet/SolrServlet.java
src/webapp/src/org/apache/solr/servlet/SolrUpdateServlet.java

There is also a clean copy on:
  http://svn.lapnap.net/solr/handler-draft/solr/
This should be easier to install - or look at (without having to install)

This version converts everything to use the new framework rather then keeping /select and
/update on the old one.  It also includes a draft proposal on how to deal with deal with GET
vs POST body vs multipart content.

It passes all the tests and seems to work exactly as before (with a few exceptions)
* /update content is returned with a ResponseWriter
* [my-BUG] I am unable to get some posted content to read its stream properly.  I had to modify:

http://svn.lapnap.net/solr/handler-draft/solr/example/exampledocs/post.sh

to call:
 curl $URL --data-binary '<commit/>' -H 'Content-type:text/xml;' 
rather then just:
 curl $URL --data-binary '<commit/>'

(any ideas?)

- - - - - - - -

I define three basic types of request handlers in: http://svn.lapnap.net/solr/handler-draft/solr/src/java/org/apache/solr/handler/
1) standard.  This gets everything from parameters (get or post) 
2) posted.  This gets a reader from the posted body:
http://svn.lapnap.net/solr/handler-draft/solr/src/java/org/apache/solr/handler/PostedRequestHandler.java
3) multipart.  This gets an iterator over each file item using commons-upload streaming API
http://jakarta.apache.org/commons/fileupload/streaming.html
http://svn.lapnap.net/solr/handler-draft/solr/src/java/org/apache/solr/handler/MultipartRequestHandler.java

I *think* this takes care of every case...  is anything missing?

The [http://svn.lapnap.net/solr/handler-draft/solr/src/webapp/src/org/apache/solr/servlet/SolrRequestFilter.java
RequestFilter] manages setting the reader or iterator for the proper handlers.

When you run the example, i added the page http://localhost:8983/solr/up.html that should
help you see a little of it in action.  

I added an example for each type:
http://svn.lapnap.net/solr/handler-draft/solr/src/java/org/apache/solr/handler/add/

- - - 

This added:
commons-io-1.2.jar
mysql-connector-java-5.0.4.jar
commons-fileupload-20070107.jar

to the library.  If we want to get rid of commons-io, I am only using IOUtils.java














> Update Plugins
> --------------
>
>                 Key: SOLR-104
>                 URL: https://issues.apache.org/jira/browse/SOLR-104
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 1.2
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>
>         Attachments: HandlerRefactoring-DRAFT-SRC.zip, HandlerRefactoring-DRAFT-SRC.zip,
HandlerRefactoring.DRAFT.patch, HandlerRefactoring.DRAFT.patch, HandlerRefactoring.DRAFT.zip
>
>
> The plugin framework should work for 'update' actions in addition to 'search' actions.
> For more discussion on this, see:
> http://www.nabble.com/Re%3A-Handling-disparate-data-sources-in-Solr-tf2918621.html#a8305828

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message