lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan McKinley (JIRA)" <>
Subject [jira] Commented: (SOLR-104) Update Plugins
Date Thu, 25 Jan 2007 11:11:49 GMT


Ryan McKinley commented on SOLR-104:

Thanks for going through this!

I'll comment on points i have answers or questions.  The rest will go
on the TODO list.

Ok, so we should make sure to put the charset into
ContentStream.getContentType() and open the Reader with:

  String charset = getCharset( stream.getContentType() );
  new InputStreamReader( stream.getStream(),  charset );

Sounds reasonable.  I took them out because (at the time) it seemed
clearer and has less duplicated code.

yes.  At some point it would also be good to make a stronger name
distinction between UpdateHandler (the thing that handles the nity
gritty lucene indexing) and the UpdateRequestHandler -- but lets save
that for another day!

As written, the StandardRequestParser:
1) checks if multipart
2) checks if it has parameters in the URL (?xxx=yyy)
  if it has parameters (?xxx=yyy) then use the RawRequestParser
  otherwise it pulls parameters from the map. (SimpleRequestParser)

To trigger raw request reading you *must* have a parameter on the URL.
 This was my design in response to Yonik's observation that curl puts
"application/x-www-form-urlencoded" in the header even if it is not
form-urlencoded encoded.

As written, it does not rely on clients putting accurate headers
(except for multipart) - it relies on a URL convention.

I only put it in there to make you happy!  I'll take it out and we can
deal with it later if necessary.

I didn't think i could get that past you!  I'll take it out and save
the pleeding for another time.

for a local file, you can use stream.url=file:///C:/pathtofile.txt,
for remote ones, you use stream.url=http://...

We should have a good notice in the config warning people to have some
security running before enabling streaming.

I had implemented it the normal way, BUT it broke many tests (since
they never call init).   The better solution is to make sure the tests
call init a standard way, but that got me into editing many files I
don't quite understand, so i opted for lazy init.

That sounds fine.  Since it is a tenative private interface, i was not
too worried about it.

> Update Plugins
> --------------
>                 Key: SOLR-104
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>    Affects Versions: 1.2
>            Reporter: Ryan McKinley
>             Fix For: 1.2
>         Attachments: commons-fileupload-20070107.jar, commons-io-1.2.jar, DispatchFilter.patch,
DispatchFilter.patch, DispatchFilter.patch, DispatchFilter.patch, DispatchFilter.patch, DispatchFilter.patch,,, HandlerRefactoring.DRAFT.patch,
> The plugin framework should work for 'update' actions in addition to 'search' actions.
> For more discussion on this, see:

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message