lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yonik Seeley" <ysee...@gmail.com>
Subject Re: svn commit: r425424 - /incubator/solr/trunk/src/java/org/apache/solr/analysis/WordDelimiterFilter.java
Date Tue, 25 Jul 2006 18:15:10 GMT
On 7/25/06, Chris Hostetter <hossman_lucene@fucit.org> wrote:
>
> : Log:
> : javadoc from Karl Wettin
>
> There is one line of code change here ... is it functionally equivilent?
> (i can't tell from the amount of context in the patch) ...

Yep, Karl included that in his patch (sent privately).  The brace at
the end matches "while(true){", so the continue is redundant.

-Yonik

> :        // NOTE: in certain cases, queue may be empty (for instance, if catenate
> : -      // and generate are both set to false).  In this case, we should proceed
> : -      // to next token rather than throwing ArrayOutOfBounds
> : -      if (queue.size() > 0) break; else continue;
> : +      // and generate are both set to false).  Only exit the loop if the queue
> : +      // is not empty.
> : +      if (queue.size() > 0) break;
> :      }

Mime
View raw message