lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <j...@apache.org>
Subject [jira] Commented: (SOLR-16) patch to allow the use of a custom query output writer
Date Fri, 19 May 2006 21:58:31 GMT
    [ http://issues.apache.org/jira/browse/SOLR-16?page=comments#action_12412595 ] 

Hoss Man commented on SOLR-16:
------------------------------

I just read through the patch -- didn't have a chance to try it out yet -- and both the functionality
and the implimentation look great!

Can i ask for one smal favor before it gets applied: some test cases showing requests work
with and with out the param specified when there are multiple options in the config?

leaving src/test/test-files/solr/conf/solrconfig.xml as is will test the default situation
where no writers are lsted ... you can modify src/test/test-files/solr/crazy-path-to-config.xml
to include both the default and some new writer and then clone the SampleTest and add some
test methods to check that you get the output you expected from various writters.

You don't even need to provide a usefull writer ... even something that just outputs some
static text would work, just put it in src/test so people know it's not a "production" writer.

most of the helper methods in AbstractSolrTestCase try to validate that the responses are
wellformed XML, but if you want to test a writer that isn't XML, it can still be done using
the TerstHarness directly ... BasicFunctionalityTest.testMultipleUpdatesPerAdd shows an example.

> patch to allow the use of a custom query output writer
> ------------------------------------------------------
>
>          Key: SOLR-16
>          URL: http://issues.apache.org/jira/browse/SOLR-16
>      Project: Solr
>         Type: New Feature

>   Components: search
>     Reporter: Mike Baranczak
>  Attachments: custom_writer.patch, custom_writer_rev2.patch
>
> This patch allows users to create their own implementation of QueryResponseWriter, and
specify that class in solrconfig.xml. The default behavior is to use XMLResponseWriter like
before. The class selection code only runs once at servlet init time, so it shouldn't have
any measurable effect on performance.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message