lucene-solr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik Hatcher <e...@ehatchersolutions.com>
Subject Re: XMLWriter escaping issue
Date Fri, 21 Apr 2006 17:12:10 GMT
I've committed a change to escape attributes and character data  
differently, all tests pass.  Let me know if there are any issues  
with it and I'd be happy to address them.

	Erik


On Apr 21, 2006, at 10:04 AM, Yonik Seeley wrote:

> On 4/21/06, Erik Hatcher <erik@ehatchersolutions.com> wrote:
>> I've corrected this in my local copy with this patch adding the
>> escaping to attribute names and the &quot; to XML.chardata_escapes.
>> The question is, is it appropriate to escape quotes everywhere, or
>> should it just be done when writing attribute values?
>
> I'd prefer just escaping quotes in attribute values as it makes things
> like debugging output that contains query strings easier to read, and
> easier to paste back into the query box for debugging from someone
> elses output.
>
> The attribute values definitely need to be XML escaped though.
>
> -Yonik


Mime
View raw message