lucene-solr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markrmil...@apache.org
Subject svn commit: r908826 - in /lucene/solr/branches/cloud/src/test/org/apache/solr/cloud: DistributedZkFailuresTest.java ZkControllerTest.java ZkSolrClientTest.java
Date Thu, 11 Feb 2010 03:30:46 GMT
Author: markrmiller
Date: Thu Feb 11 03:30:46 2010
New Revision: 908826

URL: http://svn.apache.org/viewvc?rev=908826&view=rev
Log:
remove nocommits

Modified:
    lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/DistributedZkFailuresTest.java
    lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkControllerTest.java
    lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkSolrClientTest.java

Modified: lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/DistributedZkFailuresTest.java
URL: http://svn.apache.org/viewvc/lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/DistributedZkFailuresTest.java?rev=908826&r1=908825&r2=908826&view=diff
==============================================================================
--- lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/DistributedZkFailuresTest.java
(original)
+++ lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/DistributedZkFailuresTest.java
Thu Feb 11 03:30:46 2010
@@ -22,7 +22,6 @@
 import org.apache.solr.client.solrj.embedded.JettySolrRunner;
 
 /**
- * nocommit: 
  *
  */
 public class DistributedZkFailuresTest extends AbstractDistributedZkTestCase {
@@ -105,7 +104,7 @@
     ZkController zkController = h.getCoreContainer().getZkController();
     del("*:*");
     
-    // nocommit : test too long
+    // TODO : test too long
     System.out.println("gc block");
     for(int i = 0; i < 100; i++) {
       // try and timeout

Modified: lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkControllerTest.java
URL: http://svn.apache.org/viewvc/lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkControllerTest.java?rev=908826&r1=908825&r2=908826&view=diff
==============================================================================
--- lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkControllerTest.java (original)
+++ lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkControllerTest.java Thu Feb
11 03:30:46 2010
@@ -68,9 +68,6 @@
       String shardsPath = "/collections/collection1/shards/shardid1";
       zkClient.makePath(shardsPath);
 
-      // nocommit
-      //zkClient.makePath("collections/collection1/config=collection1");
-
       addShardToZk(zkClient, shardsPath, SHARD1, URL1);
       addShardToZk(zkClient, shardsPath, SHARD2, URL2);
       addShardToZk(zkClient, shardsPath, SHARD3, URL3);
@@ -114,8 +111,6 @@
 
       }
 
-      // nocommit : check properties
-
     } finally {
       if (zkClient != null) {
         zkClient.close();

Modified: lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkSolrClientTest.java
URL: http://svn.apache.org/viewvc/lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkSolrClientTest.java?rev=908826&r1=908825&r2=908826&view=diff
==============================================================================
--- lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkSolrClientTest.java (original)
+++ lucene/solr/branches/cloud/src/test/org/apache/solr/cloud/ZkSolrClientTest.java Thu Feb
11 03:30:46 2010
@@ -125,10 +125,6 @@
       
       assertNotNull(zkClient.exists("/collections/collection4", null));
 
-    } catch(Exception e) {
-      // nocommit
-      e.printStackTrace();
-      throw e;
     } finally {
     
       if (zkClient != null) {



Mime
View raw message