lucene-solr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From markrmil...@apache.org
Subject svn commit: r908813 - /lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/ConnectionManager.java
Date Thu, 11 Feb 2010 02:52:52 GMT
Author: markrmiller
Date: Thu Feb 11 02:52:51 2010
New Revision: 908813

URL: http://svn.apache.org/viewvc?rev=908813&view=rev
Log:
remove nocommits

Modified:
    lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/ConnectionManager.java

Modified: lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/ConnectionManager.java
URL: http://svn.apache.org/viewvc/lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/ConnectionManager.java?rev=908813&r1=908812&r2=908813&view=diff
==============================================================================
--- lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/ConnectionManager.java (original)
+++ lucene/solr/branches/cloud/src/java/org/apache/solr/cloud/ConnectionManager.java Thu Feb
11 02:52:51 2010
@@ -74,9 +74,6 @@
       connected = true;
       clientConnected.countDown();
     } else if (state == KeeperState.Expired) {
-      // nocommit : much to do here - if expired, on reconnect we must remake ephemeral nodes
(re-register cores)
-      // also may need to re-watch given nodes
-      // what about on disconnect ??
       
       connected = false;
       log.info("Attempting to reconnect to ZooKeeper...");
@@ -94,16 +91,13 @@
           }
         });
       } catch (Exception e) {
-        // nocommit
-        e.printStackTrace();
+        log.error("", e);
       }
 
       log.info("Connected:" + connected);
     } else if (state == KeeperState.Disconnected) {
-      // nocommit : not sure we have to reconnect on disconnect
-      // ZooKeeper will recover when it can it seems ??
+      // ZooKeeper client will recover when it can
       connected = false;
-
     } else {
       connected = false;
     }



Mime
View raw message