Return-Path: Delivered-To: apmail-lucene-solr-commits-archive@minotaur.apache.org Received: (qmail 1779 invoked from network); 17 Dec 2009 20:48:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Dec 2009 20:48:19 -0000 Received: (qmail 51997 invoked by uid 500); 17 Dec 2009 20:48:19 -0000 Delivered-To: apmail-lucene-solr-commits-archive@lucene.apache.org Received: (qmail 51939 invoked by uid 500); 17 Dec 2009 20:48:19 -0000 Mailing-List: contact solr-commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-commits@lucene.apache.org Received: (qmail 51930 invoked by uid 99); 17 Dec 2009 20:48:19 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Dec 2009 20:48:19 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Dec 2009 20:48:17 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id B89462388AA9; Thu, 17 Dec 2009 20:47:56 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r891889 - in /lucene/solr/trunk: CHANGES.txt src/java/org/apache/solr/analysis/BufferedTokenStream.java src/test/org/apache/solr/analysis/TestBufferedTokenStream.java Date: Thu, 17 Dec 2009 20:47:56 -0000 To: solr-commits@lucene.apache.org From: shalin@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20091217204756.B89462388AA9@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: shalin Date: Thu Dec 17 20:47:56 2009 New Revision: 891889 URL: http://svn.apache.org/viewvc?rev=891889&view=rev Log: SOLR-1662 -- Added Javadocs in BufferedTokenStream and fixed incorrect cloning in TestBufferedTokenStream Modified: lucene/solr/trunk/CHANGES.txt lucene/solr/trunk/src/java/org/apache/solr/analysis/BufferedTokenStream.java lucene/solr/trunk/src/test/org/apache/solr/analysis/TestBufferedTokenStream.java Modified: lucene/solr/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/lucene/solr/trunk/CHANGES.txt?rev=891889&r1=891888&r2=891889&view=diff ============================================================================== --- lucene/solr/trunk/CHANGES.txt (original) +++ lucene/solr/trunk/CHANGES.txt Thu Dec 17 20:47:56 2009 @@ -169,6 +169,9 @@ * SOLR-1637: Remove ALIAS command +* SOLR-1662: Added Javadocs in BufferedTokenStream and fixed incorrect cloning + in TestBufferedTokenStream (Robert Muir, Uwe Schindler via shalin) + Build ---------------------- Modified: lucene/solr/trunk/src/java/org/apache/solr/analysis/BufferedTokenStream.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/analysis/BufferedTokenStream.java?rev=891889&r1=891888&r2=891889&view=diff ============================================================================== --- lucene/solr/trunk/src/java/org/apache/solr/analysis/BufferedTokenStream.java (original) +++ lucene/solr/trunk/src/java/org/apache/solr/analysis/BufferedTokenStream.java Thu Dec 17 20:47:56 2009 @@ -46,13 +46,16 @@ * public MyTokenStream(TokenStream input) {super(input);} * protected Token process(Token t) throws IOException { * if ("A".equals(t.termText()) && "B".equals(peek(1).termText())) - * write(t); + * write((Token)t.clone()); * return t; * } * } * * - * + * NOTE: BufferedTokenStream does not clone() any Tokens. This is instead the + * responsibility of the implementing subclass. In the "A" "B" => "A" "A" "B" + * example above, the subclass must clone the additional "A" it creates. + * * @version $Id$ */ public abstract class BufferedTokenStream extends TokenFilter { Modified: lucene/solr/trunk/src/test/org/apache/solr/analysis/TestBufferedTokenStream.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/test/org/apache/solr/analysis/TestBufferedTokenStream.java?rev=891889&r1=891888&r2=891889&view=diff ============================================================================== --- lucene/solr/trunk/src/test/org/apache/solr/analysis/TestBufferedTokenStream.java (original) +++ lucene/solr/trunk/src/test/org/apache/solr/analysis/TestBufferedTokenStream.java Thu Dec 17 20:47:56 2009 @@ -50,7 +50,7 @@ protected Token process(Token t) throws IOException { if ("A".equals(new String(t.termBuffer(), 0, t.termLength())) && "B".equals(new String(peek(1).termBuffer(), 0, peek(1).termLength()))) - write(t); + write((Token)t.clone()); return t; } }