Return-Path: Delivered-To: apmail-lucene-solr-commits-archive@minotaur.apache.org Received: (qmail 64803 invoked from network); 6 Aug 2009 19:30:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 6 Aug 2009 19:30:57 -0000 Received: (qmail 78044 invoked by uid 500); 6 Aug 2009 19:31:04 -0000 Delivered-To: apmail-lucene-solr-commits-archive@lucene.apache.org Received: (qmail 77972 invoked by uid 500); 6 Aug 2009 19:31:04 -0000 Mailing-List: contact solr-commits-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: solr-dev@lucene.apache.org Delivered-To: mailing list solr-commits@lucene.apache.org Received: (qmail 77935 invoked by uid 99); 6 Aug 2009 19:31:04 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Aug 2009 19:31:04 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Aug 2009 19:31:01 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 34AE22388892; Thu, 6 Aug 2009 19:30:41 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r801786 - in /lucene/solr/trunk: example/solr/conf/ src/java/org/apache/solr/handler/ src/java/org/apache/solr/util/ src/test/org/apache/solr/ src/test/test-files/solr/conf/ Date: Thu, 06 Aug 2009 19:30:40 -0000 To: solr-commits@lucene.apache.org From: yonik@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090806193041.34AE22388892@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: yonik Date: Thu Aug 6 19:30:40 2009 New Revision: 801786 URL: http://svn.apache.org/viewvc?rev=801786&view=rev Log: SOLR-1339: fix dismax to handle parse exceptions, change types in tests to use new numeric types Modified: lucene/solr/trunk/example/solr/conf/schema.xml lucene/solr/trunk/src/java/org/apache/solr/handler/DocumentAnalysisRequestHandler.java lucene/solr/trunk/src/java/org/apache/solr/util/SolrPluginUtils.java lucene/solr/trunk/src/test/org/apache/solr/ConvertedLegacyTest.java lucene/solr/trunk/src/test/org/apache/solr/DisMaxRequestHandlerTest.java lucene/solr/trunk/src/test/org/apache/solr/TestDistributedSearch.java lucene/solr/trunk/src/test/test-files/solr/conf/schema.xml Modified: lucene/solr/trunk/example/solr/conf/schema.xml URL: http://svn.apache.org/viewvc/lucene/solr/trunk/example/solr/conf/schema.xml?rev=801786&r1=801785&r2=801786&view=diff ============================================================================== --- lucene/solr/trunk/example/solr/conf/schema.xml (original) +++ lucene/solr/trunk/example/solr/conf/schema.xml Thu Aug 6 19:30:40 2009 @@ -359,6 +359,7 @@ + + + + + + + Modified: lucene/solr/trunk/src/java/org/apache/solr/handler/DocumentAnalysisRequestHandler.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/handler/DocumentAnalysisRequestHandler.java?rev=801786&r1=801785&r2=801786&view=diff ============================================================================== --- lucene/solr/trunk/src/java/org/apache/solr/handler/DocumentAnalysisRequestHandler.java (original) +++ lucene/solr/trunk/src/java/org/apache/solr/handler/DocumentAnalysisRequestHandler.java Thu Aug 6 19:30:40 2009 @@ -218,16 +218,24 @@ Set termsToMatch = new HashSet(); if (request.getQuery() != null && request.isShowMatch()) { - List tokens = analyzeValue(request.getQuery(), fieldType.getQueryAnalyzer()); - for (Token token : tokens) { - termsToMatch.add(token.term()); + try { + List tokens = analyzeValue(request.getQuery(), fieldType.getQueryAnalyzer()); + for (Token token : tokens) { + termsToMatch.add(token.term()); + } + } catch (Exception e) { + // ignore analysis exceptions since we are applying arbitrary text to all fields } } if (request.getQuery() != null) { - AnalysisContext analysisContext = new AnalysisContext(fieldType, fieldType.getQueryAnalyzer(), Collections.EMPTY_SET); - NamedList> tokens = analyzeValue(request.getQuery(), analysisContext); - fieldTokens.add("query", tokens); + try { + AnalysisContext analysisContext = new AnalysisContext(fieldType, fieldType.getQueryAnalyzer(), Collections.EMPTY_SET); + NamedList> tokens = analyzeValue(request.getQuery(), analysisContext); + fieldTokens.add("query", tokens); + } catch (Exception e) { + // ignore analysis exceptions since we are applying arbitrary text to all fields + } } Analyzer analyzer = fieldType.getAnalyzer(); Modified: lucene/solr/trunk/src/java/org/apache/solr/util/SolrPluginUtils.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/util/SolrPluginUtils.java?rev=801786&r1=801785&r2=801786&view=diff ============================================================================== --- lucene/solr/trunk/src/java/org/apache/solr/util/SolrPluginUtils.java (original) +++ lucene/solr/trunk/src/java/org/apache/solr/util/SolrPluginUtils.java Thu Aug 6 19:30:40 2009 @@ -777,7 +777,7 @@ DisjunctionMaxQuery q = new DisjunctionMaxQuery(a.tie); /* we might not get any valid queries from delegation, - * in which we should return null + * in which case we should return null */ boolean ok = false; @@ -795,7 +795,11 @@ return ok ? q : null; } else { - return super.getFieldQuery(field, queryText); + try { + return super.getFieldQuery(field, queryText); + } catch (Exception e) { + return null; + } } } Modified: lucene/solr/trunk/src/test/org/apache/solr/ConvertedLegacyTest.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/test/org/apache/solr/ConvertedLegacyTest.java?rev=801786&r1=801785&r2=801786&view=diff ============================================================================== --- lucene/solr/trunk/src/test/org/apache/solr/ConvertedLegacyTest.java (original) +++ lucene/solr/trunk/src/test/org/apache/solr/ConvertedLegacyTest.java Thu Aug 6 19:30:40 2009 @@ -591,47 +591,47 @@ // test binary float ranges and sorting assertU("44"); - assertU("441.4142135"); - assertU("44Infinity"); - assertU("44-Infinity"); - assertU("44NaN"); - assertU("442"); - assertU("44-1"); - assertU("44-987654321"); - assertU("44-999999.99"); - assertU("44-1e20"); - assertU("440"); + assertU("441.4142135"); + assertU("44Infinity"); + assertU("44-Infinity"); + assertU("44NaN"); + assertU("442"); + assertU("44-1"); + assertU("44-987654321"); + assertU("44-999999.99"); + assertU("44-1e20"); + assertU("440"); assertU(""); assertQ(req("id:44") ,"*[count(//doc)=10]" ); - assertQ(req("num_f:Infinity") + assertQ(req("num_sf:Infinity") ,"//@numFound[.='1'] " ,"//float[.='Infinity']" ); - assertQ(req("num_f:\"-Infinity\"") + assertQ(req("num_sf:\"-Infinity\"") ,"//@numFound[.='1'] " ,"//float[.='-Infinity']" ); - assertQ(req("num_f:\"NaN\"") + assertQ(req("num_sf:\"NaN\"") ,"//@numFound[.='1'] " ,"//float[.='NaN']" ); - assertQ(req("num_f:\"-1e20\"") + assertQ(req("num_sf:\"-1e20\"") ,"//@numFound[.='1']" ); - assertQ(req("id:44;num_f asc;") + assertQ(req("id:44;num_sf asc;") ,"//doc[1]/float[.='-Infinity'] " ,"//doc[last()]/float[.='NaN']" ); - assertQ(req("id:44;num_f desc;") + assertQ(req("id:44;num_sf desc;") ,"//doc[1]/float[.='NaN'] " ,"//doc[last()]/float[.='-Infinity']" ); - assertQ(req("num_f:[-1 TO 2]") + assertQ(req("num_sf:[-1 TO 2]") ,"*[count(//doc)=4]" ); - assertQ(req("num_f:[-Infinity TO Infinity]") + assertQ(req("num_sf:[-Infinity TO Infinity]") ,"*[count(//doc)=9]" ); @@ -640,50 +640,50 @@ // test binary double ranges and sorting assertU("44"); - assertU("441.4142135"); - assertU("44Infinity"); - assertU("44-Infinity"); - assertU("44NaN"); - assertU("442"); - assertU("44-1"); - assertU("441e-100"); - assertU("44-999999.99"); - assertU("44-1e100"); - assertU("440"); + assertU("441.4142135"); + assertU("44Infinity"); + assertU("44-Infinity"); + assertU("44NaN"); + assertU("442"); + assertU("44-1"); + assertU("441e-100"); + assertU("44-999999.99"); + assertU("44-1e100"); + assertU("440"); assertU(""); assertQ(req("id:44") ,"*[count(//doc)=10]" ); - assertQ(req("num_d:Infinity") + assertQ(req("num_sd:Infinity") ,"//@numFound[.='1'] " ,"//double[.='Infinity']" ); - assertQ(req("num_d:\"-Infinity\"") + assertQ(req("num_sd:\"-Infinity\"") ,"//@numFound[.='1'] " ,"//double[.='-Infinity']" ); - assertQ(req("num_d:\"NaN\"") + assertQ(req("num_sd:\"NaN\"") ,"//@numFound[.='1'] " ,"//double[.='NaN']" ); - assertQ(req("num_d:\"-1e100\"") + assertQ(req("num_sd:\"-1e100\"") ,"//@numFound[.='1']" ); - assertQ(req("num_d:\"1e-100\"") + assertQ(req("num_sd:\"1e-100\"") ,"//@numFound[.='1']" ); - assertQ(req("id:44;num_d asc;") + assertQ(req("id:44;num_sd asc;") ,"//doc[1]/double[.='-Infinity'] " ,"//doc[last()]/double[.='NaN']" ); - assertQ(req("id:44;num_d desc;") + assertQ(req("id:44;num_sd desc;") ,"//doc[1]/double[.='NaN'] " ,"//doc[last()]/double[.='-Infinity']" ); - assertQ(req("num_d:[-1 TO 2]") + assertQ(req("num_sd:[-1 TO 2]") ,"*[count(//doc)=5]" ); - assertQ(req("num_d:[-Infinity TO Infinity]") + assertQ(req("num_sd:[-Infinity TO Infinity]") ,"*[count(//doc)=9]" ); @@ -736,32 +736,32 @@ assertU("id_i:[1000 TO 1010]"); assertU("10001Z"); assertU("100110A"); - assertU("10021100"); + assertU("10021100"); assertU("1003-1"); assertU("100415"); - assertU("1005150"); + assertU("1005150"); assertU("10060"); assertU(""); assertQ(req("id_i:[1000 TO 1010]") ,"*[count(//doc)=7]" ); - assertQ(req("id_i:[1000 TO 1010]; b_i asc") + assertQ(req("id_i:[1000 TO 1010]; b_si asc") ,"*[count(//doc)=7] " ,"//doc[1]/int[.='50'] " ,"//doc[2]/int[.='100']" ); - assertQ(req("id_i:[1000 TO 1010]; b_i desc") + assertQ(req("id_i:[1000 TO 1010]; b_si desc") ,"*[count(//doc)=7] " ,"//doc[1]/int[.='100'] " ,"//doc[2]/int[.='50']" ); - assertQ(req("id_i:[1000 TO 1010]; a_i asc,b_i desc") + assertQ(req("id_i:[1000 TO 1010]; a_i asc,b_si desc") ,"*[count(//doc)=7] " ,"//doc[3]/int[.='100'] " ,"//doc[4]/int[.='50'] " ,"//doc[5]/int[.='1000']" ); - assertQ(req("id_i:[1000 TO 1010]; a_i asc,b_i asc") + assertQ(req("id_i:[1000 TO 1010]; a_i asc,b_si asc") ,"*[count(//doc)=7] " ,"//doc[3]/int[.='50'] " ,"//doc[4]/int[.='100'] " Modified: lucene/solr/trunk/src/test/org/apache/solr/DisMaxRequestHandlerTest.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/test/org/apache/solr/DisMaxRequestHandlerTest.java?rev=801786&r1=801785&r2=801786&view=diff ============================================================================== --- lucene/solr/trunk/src/test/org/apache/solr/DisMaxRequestHandlerTest.java (original) +++ lucene/solr/trunk/src/test/org/apache/solr/DisMaxRequestHandlerTest.java Thu Aug 6 19:30:40 2009 @@ -146,7 +146,7 @@ assertQ("explicit ALTQ", req( "qt", "dismax", - "q.alt", "id:blahbalh", + "q.alt", "id:9999", "fq", "id:666", "facet", "false" ) ,"//*[@numFound='0']" Modified: lucene/solr/trunk/src/test/org/apache/solr/TestDistributedSearch.java URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/test/org/apache/solr/TestDistributedSearch.java?rev=801786&r1=801785&r2=801786&view=diff ============================================================================== --- lucene/solr/trunk/src/test/org/apache/solr/TestDistributedSearch.java (original) +++ lucene/solr/trunk/src/test/org/apache/solr/TestDistributedSearch.java Thu Aug 6 19:30:40 2009 @@ -57,7 +57,7 @@ String id="id"; String t1="a_t"; - String i1="a_i"; + String i1="a_si"; String tlong = "tlong"; String oddField="oddField_s"; String missingField="missing_but_valid_field_t"; Modified: lucene/solr/trunk/src/test/test-files/solr/conf/schema.xml URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/test/test-files/solr/conf/schema.xml?rev=801786&r1=801785&r2=801786&view=diff ============================================================================== --- lucene/solr/trunk/src/test/test-files/solr/conf/schema.xml (original) +++ lucene/solr/trunk/src/test/test-files/solr/conf/schema.xml Thu Aug 6 19:30:40 2009 @@ -42,10 +42,20 @@ These are provided more for backward compatability, allowing one to create a schema that matches an existing lucene index. --> - - - - + + + + + + + + + + + + + + + + + - + - + - - + + + + + + + + + + + + + + @@ -467,7 +491,7 @@ - +