Mailing-List: contact pylucene-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: pylucene-dev@lucene.apache.org
From: Ruediger Meier <sweet_f_a@gmx.de>
To: pylucene-dev@lucene.apache.org
Subject: Re: [VOTE] Release PyLucene 6.5.0 (rc1) (now with Python 3 support)
Date: Wed, 29 Mar 2017 23:18:13 +0200
User-Agent: KMail/1.9.10
Cc: Petrus =?utf-8?q?Hyv=C3=B6nen?= <petrus.hyvonen@gmail.com>
References: <alpine.OSX.2.01.1703271509330.89223@yuzu.local> <A54A0110-6E17-48D0-BD69-4952D8ED400B@apache.org> <CAP9QEeefNhBWw6FcinNY1YSKvr29on5Yvg+5DJS1rOUFPSJbkQ@mail.gmail.com>
In-Reply-To: <CAP9QEeefNhBWw6FcinNY1YSKvr29on5Yvg+5DJS1rOUFPSJbkQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <201703292318.14098.sweet_f_a@gmx.de>
archived-at: Wed, 29 Mar 2017 21:18:20 -0000

On Wednesday 29 March 2017, Petrus Hyv=C3=B6nen wrote:
> Hi,
>
> Yes, there are windows users :)
>
> I've ran a quick test, it builds fine on python 2.7 but I'm getting
> some linker error under python 3.6 and 3.5 (didn't try lower).
>
> The linker error states:
>
> jcc3/sources/jcc.cpp(202): error C3688: invalid literal suffix
> 'PRIxMAX'; literal operator or literal operator template
> 'operator ""PRIxMAX' not found
> jcc3/sources/jcc.cpp(202): error C2664: 'int sprintf(char *const
> ,const char *const ,...)': cannot convert argument 2 fr
> om 'int' to 'const char *const '
> jcc3/sources/jcc.cpp(202): note: Conversion from integral type to
> pointer type requires reinterpret_cast, C-style cast o
> r function-style cast
> error: command 'C:\\Program Files (x86)\\Microsoft Visual Studio
> 14.0\\VC\\BIN\\amd64\\cl.exe' failed with exit status 2
>
> the jcc.cpp code is:
> static PyObject *t_jccenv_strhash(PyObject *self, PyObject *arg)
> {
>     static const size_t hexdig =3D sizeof(uintmax_t) * 2;
>     uintmax_t hash =3D (uintmax_t) PyObject_Hash(arg);
>     char buffer[hexdig + 1];
>
>     sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
>     return PyUnicode_FromStringAndSize(buffer, hexdig);
> }
>
> I don't understand the PRIxMAX stuff there, what does it mean?

Could you try to change=20
    sprintf(buffer, "%0*"PRIxMAX, (int) hexdig, hash);
to
    sprintf(buffer, "%0*%jx", (int) hexdig, hash);

or if it still not works
    sprintf(buffer, "%0*%llx", (int) hexdig, (unsigned long long)hash);

cu,
Rudi