Mailing-List: contact pylucene-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: pylucene-dev@lucene.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Date: Sun, 7 Oct 2012 18:08:06 -0700 (PDT)
From: Andi Vajda <vajda@apache.org>
Reply-To: Andi Vajda <vajda@apache.org>
To: pylucene-dev@lucene.apache.org
Subject: Re: JCC linux patch
In-Reply-To: 
 <CAL+07jyBpoa-JevYUoj3fcyJKUKZFLsmLU2HpHe+V7ukf3_ymQ@mail.gmail.com>
Message-ID: <alpine.OSX.2.01.1210071757340.51376@yuzu.local>
References: 
 <CAL+07jzM0Q52VYY5NMdTkLHC_78ch1hZNCm+i+FU4GRmy+0+dQ@mail.gmail.com>
 <E27B585F-F990-41C2-A6E8-D6BC93F1F92A@apache.org>
 <CAL+07jxVPosyhmBk5RA1Mp3M8JJ9ZVnB3+rG-1uF1nvERSiPpQ@mail.gmail.com>
 <80508E23-9CCE-414C-BCE4-D4828066DB9E@apache.org>
 <CAL+07jzs2kNNZPrcUm0eijJw1Nv7q9P51H=s5h2F3_OyQZ0xjg@mail.gmail.com>
 <alpine.OSX.2.01.1210012203190.45299@yuzu.local>
 <CAL+07jyBpoa-JevYUoj3fcyJKUKZFLsmLU2HpHe+V7ukf3_ymQ@mail.gmail.com>
User-Agent: Alpine 2.01 (OSX 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed


  Hi Caleb,

On Tue, 2 Oct 2012, Caleb Burns wrote:

> On Tue, Oct 2, 2012 at 1:04 AM, Andi Vajda <vajda@apache.org> wrote:
>>
>> Great. Now, in order to get the patch to me, you need to either:
>>   - open a bug in JIRA and attach it there (PYLUCENE project)
>>   - or send it to me directly
>
> I opened a bug on JIRA for PyLucene and added the patch:
> https://issues.apache.org/jira/browse/PYLUCENE-24
>
>> If you send patches to the list, they get eaten by the list processor.
>> Sorry.
>
> I didn't realize attachments were filtered.

I took a look at your patch. A couple of questions:

- In jcc/helpers/linux.py, you seem to be getting rid of the 0.6.15
   setuptools case. How is that version handled now ?
   I remember adding this case last May since it's a version out there in the
   wild and patching it failed as it needs the 0.6c7 patch.
   Am I reading this correctly that you're assuming 0.6.15 to be compatible
   with 0.6.1 distribute ?

- You have a line of new code in linux.py that says:
   +            if build_ext.use_stubs or os.name == 'nt':
   How can os.name be 'nt' when linux.py is being run ?

Andi..