Mailing-List: contact pylucene-dev-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: pylucene-dev@lucene.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
Date: Mon, 18 Jul 2011 12:53:53 -0700 (PDT)
From: Andi Vajda <vajda@apache.org>
Reply-To: Andi Vajda <vajda@apache.org>
To: pylucene-dev@lucene.apache.org
Subject: Re: [VOTE] Release PyLucene 3.3.0
In-Reply-To: <4E109D32.2050600@cheimes.de>
Message-ID: <alpine.OSX.2.01.1107181248020.935@yuzu.local>
References: <alpine.OSX.2.01.1012042228030.86199@yuzu.local>
 <alpine.OSX.2.01.1104021316460.8201@yuzu.local>
 <alpine.OSX.2.01.1106061348340.42688@yuzu.local>
 <alpine.OSX.2.01.1107010523140.5486@yuzu>
 <CAL8PwkaayCrvUoysbjn_G3cOBTNBQmhBf8ThMKALM6dRZo4Y2g@mail.gmail.com>
 <CAL8PwkbQMywrhgZ1jqn5SO6yvZxbmdjOPC7DMrmwLtmBNA1RQg@mail.gmail.com>
 <alpine.OSX.2.01.1107030910370.6513@yuzu.home> <4E109D32.2050600@cheimes.de>
User-Agent: Alpine 2.01 (OSX 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed


On Sun, 3 Jul 2011, Christian Heimes wrote:

> Am 03.07.2011 18:17, schrieb Andi Vajda:
>> What kind of errors ?
>>
>> So I added the grouping module to the PyLucene branch_3x build and it "just
>> built" (tm). I even committed the change to the build (rev 1142455) but I
>> didn't check that the grouping module was functional in PyLucene as I didn't
>> port any unit tests or even know much about it.
>
> I'm getting an error on my box, too.

I fixed a bug with what looks like strange behaviour of the 
java.lang.reflect.Constructor class: for a non-static inner class, it 
appears that Constructor.getGenericParameterTypes() is not returning the 
implicit first parameter - the instance of the declaring outer class - that 
Constructor.getParameterTypes() is returning.
This difference is not documented (nor is the implicit first parameter 
returned by the non-generic version).

Could you please get the latest jcc from trunk/branch_3x (version 2.10) and 
verify that my fix really fixes it. I was able to reproduce and explain the 
bug but would like to be sure I'm not missing something.

I re-enabled the grouping module on branch_3x.
Once verified, I'll spin a new PyLucene 3.3 release candidate as the 
previous didn't garner the 3 required PMC votes anyway.

Thanks !

Andi..

>
> In file included from build/_lucene/__wrap01__.cpp:39469:0:
> build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:83:
> error: ?AbstractSecondPassGroupingCollector? in namespace
> ?org::apache::lucene::search::grouping? does not name a type
> build/_lucene/org/apache/lucene/search/grouping/AbstractSecondPassGroupingCollector$SearchGroupDocs.h:55:160:
> error: ISO C++ forbids declaration of ?parameter? with no type
> build/_lucene/__wrap01__.cpp:39503:132: error:
> ?AbstractSecondPassGroupingCollector? in namespace
> ?org::apache::lucene::search::grouping? does not name a type
> build/_lucene/__wrap01__.cpp:39503:211: error: ISO C++ forbids
> declaration of ?a0? with no type
> build/_lucene/__wrap01__.cpp: In constructor
> ?org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector$SearchGroupDocs::AbstractSecondPassGroupingCollector$SearchGroupDocs(const
> int&, const java::lang::Object&, const
> org::apache::lucene::search::TopDocsCollector&)?:
> build/_lucene/__wrap01__.cpp:39503:394: error: request for member
> ?this$? in ?a0?, which is of non-class type ?const int?
> build/_lucene/__wrap01__.cpp: In function ?int
> org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs_init_(org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector$SearchGroupDocs*,
> PyObject*, PyObject*)?:
> build/_lucene/__wrap01__.cpp:39608:25: error:
> ?AbstractSecondPassGroupingCollector? is not a member of
> ?org::apache::lucene::search::grouping?
> build/_lucene/__wrap01__.cpp:39608:102: error: expected ?;? before ?a0?
> build/_lucene/__wrap01__.cpp:39615:30: error:
> ?org::apache::lucene::search::grouping::AbstractSecondPassGroupingCollector?
> has not been declared
> build/_lucene/__wrap01__.cpp:39615:30: error: ?a0? was not declared in
> this scope
> build/_lucene/__wrap01__.cpp:39615:30: error:
> ?org::apache::lucene::search::grouping::t_AbstractSecondPassGroupingCollector?
> has not been declared
> error: command 'gcc' failed with exit status 1
>
> Ubuntu 11.04 x86_64
> GCC 4.5.2
> Python 2.7.2
>
> Christian
>