lucene-lucene-net-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Mirvoda (JIRA)" <j...@apache.org>
Subject [Lucene.Net] [jira] [Commented] (LUCENENET-85) SupportClass.Parse and System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator
Date Tue, 22 Mar 2011 12:45:09 GMT

    [ https://issues.apache.org/jira/browse/LUCENENET-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009628#comment-13009628
] 

Sergey Mirvoda commented on LUCENENET-85:
-----------------------------------------

Why invariant culture? 
You should always use CurrentCulture or require cultureInfo as a parameter.
If you use invariant culture you will fail with parsing _any_ culture specific strings for
example in Russia ,(not .) is a decimal separator.

and I also think that method above is wrong.

> SupportClass.Parse and System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENENET-85
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-85
>             Project: Lucene.Net
>          Issue Type: Bug
>            Reporter: Digy
>            Assignee: George Aroush
>            Priority: Minor
>         Attachments: SupportClass.patch
>
>
> Again System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator
problem
>        public static System.Single Parse(System.String s)
>         {
>             try
>             {
>                 if (s.EndsWith("f") || s.EndsWith("F"))
>                     return System.Single.Parse(s.Substring(0, s.Length - 1).Replace(".",
System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator));
>                 else
>                     return System.Single.Parse(s.Replace(".", System.Globalization.CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator));
>             }
>             catch(System.FormatException fex)
>             {
>                 throw fex;					
>             }
>         }

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message