Mailing-List: contact java-user-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-user@lucene.apache.org
Subject: Re: Adding TokenFilters to a CustomAnalyzer is too inflexible
To: java-user@lucene.apache.org
References: <7df6aa92-635f-5d97-ca90-e8a4474032dd@wolfram.com>
 <047a01d2a921$7ce17150$76a453f0$@thetaphi.de>
From: =?UTF-8?Q?Nicol=c3=a1s_Lichtmaier?= <nicolasl@wolfram.com>
Message-ID: <812ac2d2-4faa-2011-cf70-2389de78d044@wolfram.com>
Date: Thu, 30 Mar 2017 20:26:25 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <047a01d2a921$7ce17150$76a453f0$@thetaphi.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
archived-at: Thu, 30 Mar 2017 23:26:47 -0000

Ok, so a flexible interface would be to be able to pass some 
TokenFilterFactory that would be called each time a TokenFilter is 
needed. Would that be ok?


El 30/03/17 a las 03:47, Uwe Schindler escribió:
> A TokenFilter object already build won't work, because the Analyzer must create new instances of the TokenFilters as needed.
>
> Uwe
>
> -----
> Uwe Schindler
> Achterdiek 19, D-28357 Bremen
> http://www.thetaphi.de
> eMail: uwe@thetaphi.de
>
>> -----Original Message-----
>> From: Nicolás Lichtmaier [mailto:nicolasl@wolfram.com]
>> Sent: Wednesday, March 29, 2017 7:00 PM
>> To: java-user@lucene.apache.org
>> Subject: Adding TokenFilters to a CustomAnalyzer is too inflexible
>>
>> I'm using a CustomAnalyzer.Builder to set up an analyzer. I now would
>> like to add synonym processing, I already have the SynonymMap in memory.
>> But the builder interface only takes String arguments. Wouldn't it be a
>> good thing to add a method to CustomAnalyzer.Builder to add a
>> TokenFilter object already constructed, instead of only being able to
>> pass a class name? That is: overload the addTokenFilter method to do
>> this: builder.addTokenizer(new MyTokenFilter(....));
>>
>> Am I missing something?
>>
>> Should I create a patch with this minor modification and send it?
>>
>> Thanks!
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-user-help@lucene.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-user-help@lucene.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org