lucene-java-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Charles <e...@apache.org>
Subject Re: IndexSearcher.close() removed in 4.0
Date Mon, 18 Feb 2013 22:30:03 GMT
Hi,
Why not having the IS#close() calling the wrapped IR#close() ?

I would be happier having to only deal with the Searcher once created 
and forget it wraps a Reader: I create a Searcher, I close it.

Thx, Eric

On 18/02/2013 22:20, Simon Willnauer wrote:
> On Mon, Feb 18, 2013 at 7:32 PM, saisantoshi <saisantoshi76@gmail.com> wrote:
>> I understand from the JIRA ticket(Lucene-3640) that the IndexSearcher.close()
>> is no-op operation but not very clear on why it is a no-op? Could someone
>> shed some light on this? We were using this method in the older versions and
>> is it safe now to remove this call. Just want to understand the consequences
>> before we make any changes? Is there any alternative that we need to use
>> here?
>
> Hey,
>
> previous version had a constructor that accepted a directory [1] if
> you used this constructor IndexSearcher#close did also close the index
> reader that was created. Since we removed this constructor we also
> removed close since it's a no-op. IndexSearcher is just a wrapper to
> add some functionality on top of the reader. You can ignore the
> IS#close() if you closing the IndexReader properly.
>
> simon
> [1] http://lucene.apache.org/core/3_6_2/api/core/org/apache/lucene/search/IndexSearcher.html#IndexSearcher(org.apache.lucene.store.Directory)
>>
>> Thanks,
>> Sai
>>
>>
>>
>> --
>> View this message in context: http://lucene.472066.n3.nabble.com/IndexSearcher-close-removed-in-4-0-tp4041177.html
>> Sent from the Lucene - Java Users mailing list archive at Nabble.com.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: java-user-help@lucene.apache.org
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-user-help@lucene.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org


Mime
View raw message