Return-Path: X-Original-To: apmail-lucene-java-user-archive@www.apache.org Delivered-To: apmail-lucene-java-user-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6CB01D55E for ; Wed, 21 Nov 2012 13:51:09 +0000 (UTC) Received: (qmail 33566 invoked by uid 500); 21 Nov 2012 13:51:07 -0000 Delivered-To: apmail-lucene-java-user-archive@lucene.apache.org Received: (qmail 33398 invoked by uid 500); 21 Nov 2012 13:51:07 -0000 Mailing-List: contact java-user-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-user@lucene.apache.org Delivered-To: mailing list java-user@lucene.apache.org Received: (qmail 33385 invoked by uid 99); 21 Nov 2012 13:51:06 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Nov 2012 13:51:06 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [193.196.8.10] (HELO linux3.ids-mannheim.de) (193.196.8.10) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Nov 2012 13:51:01 +0000 Received: from linux2.ids-mannheim.de ([10.0.1.1]) by linux3.ids-mannheim.de with smtp (Exim 4.72) (envelope-from ) id 1TbAhK-0005SH-2j for java-user@lucene.apache.org; Wed, 21 Nov 2012 14:50:39 +0100 Received: (qmail 8072 invoked from network); 21 Nov 2012 13:50:37 -0000 Received: from unknown (HELO ?10.99.1.49?) (10.99.1.49) by linux2.ids-mannheim.de with SMTP; 21 Nov 2012 13:50:37 -0000 Message-ID: <50ACDC2D.2030601@ids-mannheim.de> Date: Wed, 21 Nov 2012 14:50:37 +0100 From: Carsten Schnober Organization: Institut =?ISO-8859-15?Q?f=FCr_Deutsche_Sprache?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121028 Thunderbird/16.0.2 MIME-Version: 1.0 To: java-user Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit X-SA-Do-Not-Run: Yes X-SA-Exim-Connect-IP: 10.0.1.1 X-SA-Exim-Rcpt-To: java-user@lucene.apache.org X-SA-Exim-Mail-From: schnober@ids-mannheim.de X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on linux3.ids-mannheim.de X-Spam-Level: Subject: Potential Resource Leak warning in Analyer.createComponents() X-SA-Exim-Version: 4.2.1 (built Mon, 03 Jul 2006 09:34:15 +0200) X-SA-Exim-Scanned: Yes (on linux3.ids-mannheim.de) X-Virus-Checked: Checked by ClamAV on apache.org X-Old-Spam-Status: No, score=-2.1 required=3.0 tests=BAYES_00,GREYLIST_ISWHITE, RDNS_NONE autolearn=no version=3.3.2 Hi, I use a custom analyzer and tokenizer. The analyzer is very basic and it merely comprises the method createComponents(): ------------------------------------------------------------- @Override protected TokenStreamComponents createComponents(String fieldName, Reader reader) { return new TokenStreamComponents(new KoraTokenizer(reader)); } ------------------------------------------------------------- Eclipse gives me a warning though "potential resource leak" because the tokenizer is never closed. This is clearly true but is it not desirable either, is it? To get rid of the warning, I had experimentally changed the method to this: Tokenizer source = new KoraTokenizer(reader); TokenStreamComponents ts = new TokenStreamComponents(source); source.close(); return ts; This yields what I had expected, namely a null TokenStream during analysis. So regarding the results, I think the initial version is right, but I am suspicious against the resource leak warning. How serious is it? Best, Carsten -- Institut f�r Deutsche Sprache | http://www.ids-mannheim.de Projekt KorAP | http://korap.ids-mannheim.de Tel. +49-(0)621-43740789 | schnober@ids-mannheim.de Korpusanalyseplattform der n�chsten Generation Next Generation Corpus Analysis Platform --------------------------------------------------------------------- To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org For additional commands, e-mail: java-user-help@lucene.apache.org