Mailing-List: contact java-user-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-user@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of markrmiller@gmail.com
 designates 209.85.212.48 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1084)
Subject: Re: Extracting span terms using WeightedSpanTermExtractor
From: Mark Miller <markrmiller@gmail.com>
In-Reply-To: 
 <CAHBqfespyGuvdBuCsxLtQFimaeiE=ZyEntSP5DDptPEorw3CqA@mail.gmail.com>
Date: Thu, 7 Jul 2011 19:47:30 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <8DF98893-A7F7-4EE6-9357-8CDA0AD3C15B@gmail.com>
References: 
 <CAHBqfetQ+gtUu7RnpCCHOSkG46sF_PyXFusCF=hfqU07DTEE8w@mail.gmail.com>
 <F158D191-C949-4E20-B610-BF65DC13DF8C@gmail.com>
 <CAHBqfespyGuvdBuCsxLtQFimaeiE=ZyEntSP5DDptPEorw3CqA@mail.gmail.com>
To: java-user@lucene.apache.org


On Jul 7, 2011, at 5:14 PM, Jahangir Anwari wrote:

> I did noticed a strange issue though. When the query is just a
> PhraseQuery(e.g. "everlasting glory"), getWeightedSpanTerms() returns =
all
> the span terms along with their span positions. But when the query is =
a
> BooleanQuery containing phrase and non-phrase terms(e.g. "everlasting
> glory"+unity), getWeightedSpanTerms() returns all the span terms but =
the
> span positions are returned only for the phrase terms(i.e. =
"everlasting" and
> "glory"). Span positions for the non-phrase term(i.e. "unity") is =
empty. Any
> ideas why this could be happening?


Positions are only collected for "position sensitive" queries. The =
Highlighter framework that I plugged this into already runs through the =
TokenStream one token at a time - to highlight a TermQuery, there is no =
need to consult positions - just highlight every occurrence seen while =
marching through the TokenStream. Which means there is no need to find =
those positions either.

If you are looking for those positions, here is a patch to calculate =
them for TermQuerys as well. If you open a JIRA issue, seems like a =
reasonable option to add to the class.

Index: =
lucene/contrib/highlighter/src/java/org/apache/lucene/search/highlight/Wei=
ghtedSpanTermExtractor.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- =
lucene/contrib/highlighter/src/java/org/apache/lucene/search/highlight/Wei=
ghtedSpanTermExtractor.java	(revision 1143407)
+++ =
lucene/contrib/highlighter/src/java/org/apache/lucene/search/highlight/Wei=
ghtedSpanTermExtractor.java	(working copy)
@@ -133,7 +133,7 @@
       sp.setBoost(query.getBoost());
       extractWeightedSpanTerms(terms, sp);
     } else if (query instanceof TermQuery) {
-      extractWeightedTerms(terms, query);
+      extractWeightedSpanTerms(terms, new =
SpanTermQuery(((TermQuery)query).getTerm()));
     } else if (query instanceof SpanQuery) {
       extractWeightedSpanTerms(terms, (SpanQuery) query);
     } else if (query instanceof FilteredQuery) {


- Mark Miller
lucidimagination.com


---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org