Mailing-List: contact java-user-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-user@lucene.apache.org
Received-SPF: pass (nike.apache.org: domain of eirbjo@gmail.com designates
 209.85.220.228 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=BrdT++cHazub/0i5QmoFTAln5xBQdsmsKJroEZ8r2GMjKm/v0dlPyvSJMu7rp6ZDT8
         XJ8Au6yyzx7EFbPY4hMzsGctoVXB2FfeMAAhXeVwlXIaTl6XZM2JfJy/2sdh6ftEBFvO
         Wves8g7y/uR3nC/U7OBrfWFvk6ix1VbG+aldM=
MIME-Version: 1.0
Date: Wed, 2 Dec 2009 18:44:05 +0100
Message-ID: <34660cca0912020944n2b6b7965i6753f1b47b8f4820@mail.gmail.com>
Subject: Potential leak of file resources in SpellChecker
From: =?ISO-8859-1?Q?Eirik_Bj=F8rsn=F8s?= <eirbjo@gmail.com>
To: java-user@lucene.apache.org
Content-Type: multipart/mixed; boundary=0016e6d9a057c05cf20479c26bd6

--0016e6d9a057c05cf20479c26bd6
Content-Type: text/plain; charset=ISO-8859-1

Hi,

I'm using SpellChecker (in Lucene contrib) to help users of SVNSearch
who can't type right:

http://svnsearch.org/svnsearch/repos/ASF/search?logMessage=lusene

SpellChecker works very well for my purpose, but I've encountered a
possible file resource leak issue:

I can't find any way to close the IndexSearcher (and IndexReader) that
is being used by SpellChecker internally.

I've worked around this issue by keeping a single SpellChecker open
for each repository, but I'd really like to be able to close it and
reopen it on demand without leaking file descriptors.

Could we add a close() method to SpellChecker that will close the
IndexSearcher and null the reference to it? And perhaps add some code
that reopens the searcher if the reference to it is null? Or would
that break thread safety of SpellChecker?

The attached patch adds a close method but leaves it to the user to
call setSpellIndex to reopen the searcher.

Thanks,
Eirik.


--0016e6d9a057c05cf20479c26bd6
Content-Type: text/plain; charset=us-ascii


---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org
--0016e6d9a057c05cf20479c26bd6--