Mailing-List: contact java-user-help@lucene.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-user@lucene.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Message-Id: <1194623412.30050.1220454289@webmail.messagingengine.com>
From: "Michael McCandless" <lucene@mikemccandless.com>
To: java-user@lucene.apache.org
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ISO-8859-1"
MIME-Version: 1.0
References: <47347A26.5000205@fredhopper.com>
Subject: Re: - lock improvement suggestion
In-Reply-To: <47347A26.5000205@fredhopper.com>
Date: Fri, 09 Nov 2007 10:50:12 -0500


I agree, we should not ignore the return value here.  I think throwing an
exception if it returns false is the right thing to do?  Though, if it's
a checked exception, that's not a backwards compatible change...

Mike

"Nikolay Diakov" <nikolay.diakov@fredhopper.com> wrote:
> I have briefly reviewed the SimpleFSLock of Lucene 2.1 and 2.2. I see 
> that the lock release mechanism does not check the return value of
> delete:
> 
>    public void release() {
>      lockFile.delete();
>    }
> 
> On most linux-es this can never return false, however under some windows 
> FS if someone (a virus scanner) touches the file at the proper 
> (improper) time, one may get a delete failure and get a false value. In 
> the original code this means that the directory stays locked forever 
> (unless someone does double unlocking or until a clearLock from the lock 
> factory). For diagnosting purposes, it may be a good idea to throw an 
> exception in that case. Alternatively, release() may return a boolean up 
> the chain, however this may require more changes in the code using the 
> release(). Just a suggestion.
> 
> Cheers,
>    Nikolay
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
> For additional commands, e-mail: java-user-help@lucene.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-user-help@lucene.apache.org