Return-Path: Delivered-To: apmail-lucene-java-user-archive@www.apache.org Received: (qmail 19238 invoked from network); 7 Mar 2007 02:34:50 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Mar 2007 02:34:50 -0000 Received: (qmail 72891 invoked by uid 500); 7 Mar 2007 02:34:51 -0000 Delivered-To: apmail-lucene-java-user-archive@lucene.apache.org Received: (qmail 72852 invoked by uid 500); 7 Mar 2007 02:34:51 -0000 Mailing-List: contact java-user-help@lucene.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-user@lucene.apache.org Delivered-To: mailing list java-user@lucene.apache.org Received: (qmail 72841 invoked by uid 99); 7 Mar 2007 02:34:51 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2007 18:34:51 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [212.226.92.15] (HELO monkey.teamware.com) (212.226.92.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2007 18:34:40 -0800 Received: from nimitz (nimitz.teamw.com [10.142.128.10]) by monkey.teamware.com (8.13.1/8.13.1) with ESMTP id l272YD69010556 for ; Wed, 7 Mar 2007 04:34:13 +0200 Received: from [10.142.3.11] ([10.142.3.11]) by nimitz with ESMTP id m374ybl2; 7 Mar 2007 04:34:00 +0200 Message-ID: <45EE24A2.1060303@teamware.com> Date: Wed, 07 Mar 2007 13:34:10 +1100 From: Antony Bowesman Organization: Teamware Group User-Agent: Thunderbird 1.5 (Windows/20051201) MIME-Version: 1.0 To: java-user@lucene.apache.org Subject: Re: Caching of BitSets from filters and Query.equals() References: <45ED124E.9060903@teamware.com> <45C35990-0EF3-496C-BC85-24DDED65C21D@ehatchersolutions.com> <45ED51F2.30507@teamware.com> <45EDCD91.8030900@teamware.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.6 (monkey.teamware.com [212.226.92.15]); Wed, 07 Mar 2007 04:34:13 +0200 (EET) X-TWG-MailScanner-Information: See www.mailscanner.info for information X-TWG-MailScanner: Found to be clean X-TWG-MailScanner-SpamCheck: not spam, SpamAssassin (score=0.001, required 5, autolearn=not spam, BAYES_50 0.00) X-MailScanner-From: adb@teamware.com X-Virus-Checked: Checked by ClamAV on apache.org Chris Hostetter wrote: > : equals to get q1.equals(q2). The core Lucene Query implementations do override > : equals() to satisfy that test, but some of the contrib Query implementations do > : not override equals, so you would never see the same Query twice and caching > : BitSets for those Query instances would be a waste of time. > > fileing bugs about those Query instances would be helpful .. bugs with > patches that demonstrate the problem in unit tests and fix them would be > even more helpful :) OK, I'll put it on my todo list, but I've got to get the product out of the door this month... > These classes may prove useful in submitting test cases... > > http://svn.apache.org/viewvc/lucene/java/trunk/src/test/org/apache/lucene/search/QueryUtils.java?view=log > http://svn.apache.org/viewvc/lucene/java/trunk/src/test/org/apache/lucene/search/CheckHits.java Thanks for those pointers. Antony --------------------------------------------------------------------- To unsubscribe, e-mail: java-user-unsubscribe@lucene.apache.org For additional commands, e-mail: java-user-help@lucene.apache.org