Return-Path: Delivered-To: apmail-jakarta-lucene-user-archive@www.apache.org Received: (qmail 10322 invoked from network); 10 Mar 2004 23:33:52 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 10 Mar 2004 23:33:52 -0000 Received: (qmail 29181 invoked by uid 500); 10 Mar 2004 23:33:27 -0000 Delivered-To: apmail-jakarta-lucene-user-archive@jakarta.apache.org Received: (qmail 29129 invoked by uid 500); 10 Mar 2004 23:33:27 -0000 Mailing-List: contact lucene-user-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Lucene Users List" Reply-To: "Lucene Users List" Delivered-To: mailing list lucene-user@jakarta.apache.org Received: (qmail 29093 invoked from network); 10 Mar 2004 23:33:27 -0000 Received: from unknown (HELO c000.snv.cp.net) (209.228.32.66) by daedalus.apache.org with SMTP; 10 Mar 2004 23:33:27 -0000 Received: (cpmta 19745 invoked from network); 10 Mar 2004 15:33:33 -0800 Received: from 24.51.109.181 (HELO ?192.168.1.100?) by smtp.hatcher.net (209.228.32.66) with SMTP; 10 Mar 2004 15:33:33 -0800 X-Sent: 10 Mar 2004 23:33:33 GMT Mime-Version: 1.0 (Apple Message framework v612) In-Reply-To: <404F73B2.5020503@newsmonster.org> References: <404D22CF.7050705@newsmonster.org> <404D8B2E.2020701@newsmonster.org> <404E0320.9010303@apache.org> <404E1465.4030503@newsmonster.org> <404E8A1C.6060809@newsmonster.org> <404F73B2.5020503@newsmonster.org> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <55DCBB78-72EB-11D8-A324-000393A564E6@ehatchersolutions.com> Content-Transfer-Encoding: 7bit From: Erik Hatcher Subject: Re: DocumentWriter, StopFilter should use HashMap... (patch) Date: Wed, 10 Mar 2004 18:33:29 -0500 To: "Lucene Users List" X-Mailer: Apple Mail (2.612) X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On Mar 10, 2004, at 2:59 PM, Kevin A. Burton wrote: >> I refuse to expose HashSet... sorry! :) But I did wrap what is >> passed in, like above, in a HashSet in my latest commit. > > Hm... You're doing this EVEN if the caller passes a HashSet directly?! Well it was in the ctor. But I guess I'm not seeing all the times the filter is being constructed to make this a cause a performance hit. > Why do you have a problem exposing a HashSet/Map... it SHOULD be a > Hash based implementation. Doing anything else is just wrong and > would seriously slow down Lucene indexing. Just semantically, it is a "set" of stop words - so in theory it shouldn't matter the actual implementation. I'm an interface purist at heart. > Also... you're HashSet constructor has to copy values from the > original HashSet into the new HashSet ... not very clean and this can > just be removed by forcing the caller to use a HashSet (which they > should). I've caved in and gone HashSet all the way. Erik --------------------------------------------------------------------- To unsubscribe, e-mail: lucene-user-unsubscribe@jakarta.apache.org For additional commands, e-mail: lucene-user-help@jakarta.apache.org